bazel: never strip output binaries #128128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rickystewart
added
backport-23.1.x
To date, binaries are stripped by default when building with Bazel. We skip stripping for release binaries (via `-c opt`) and if you're building with the `dev` configuration (many developers use this configuration as `dev doctor` guides you to). This has led to some confusion as these mechanisms are non-obvious, leading some to wonder why their binaries are (or are not) stripped. We simplify this by *never* stripping. Since release binaries are not stripped, they are unaffected by this change. Only developers building without the `dev` config and CI jobs that don't set `-c opt` would be affected. Epic: CRDB-17171 Release note: None
rickystewart
force-pushed
the
strip-never
branch
from
2fcfbe9 to
51dc6fb
Compare
rail
approved these changes
Aug 1, 2024
|
bors r=rail |
This was referenced Aug 2, 2024
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 51dc6fb to blathers/backport-release-23.1-128128: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To date, binaries are stripped by default when building with Bazel. We skip stripping for release binaries (via
-c opt) and if you're building with thedevconfiguration (many developers use this configuration asdev doctorguides you to). This has led to some confusion as these mechanisms are non-obvious, leading some to wonder why their binaries are (or are not) stripped. We simplify this by never stripping. Since release binaries are not stripped, they are unaffected by this change. Only developers building without thedevconfig and CI jobs that don't set-c optwould be affected.Epic: CRDB-17171
Release note: None