-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-24.2: peer: fix redaction of peer (re-)connects #133323
base: release-24.2
Are you sure you want to change the base?
Conversation
Currently, when logging the connection or reconnection of a peer, the log is line fully redacted. This impedes diagnosing network issues. Fix the redaction by printing a `SafeString` into the buffer for bare strings, rather than a raw `string`, which is marked as unsafe by default. Move all other templated strings to use `buf.Printf` with `redact.Safe` for arguments. Fix #133218. Release note: None.
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Reminder: it has been 3 weeks please merge or close your backport! |
Backport 1/1 commits from #133219 on behalf of @nicktrav.
/cc @cockroachdb/release
Currently, when logging the connection or reconnection of a peer, the log is line fully redacted. This impedes diagnosing network issues.
Fix the redaction by printing a
SafeString
into the buffer, rather than a rawstring
, which is marked as unsafe by default.Fix #133218.
Release note: None.
Release justification: Low risk obs change.