-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2: roachtest: update multitenant/distsql to use new roachprod service APIs #116525
Merged
herkolategan
merged 6 commits into
cockroachdb:release-23.2
from
herkolategan:backport23.2-115599
Jan 9, 2024
Merged
release-23.2: roachtest: update multitenant/distsql to use new roachprod service APIs #116525
herkolategan
merged 6 commits into
cockroachdb:release-23.2
from
herkolategan:backport23.2-115599
Jan 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Epic: None Release Note: None
Previously the cluster interface only exposed a method to start storage nodes, but that is insufficient to start virtual clusters that have a separate method on the `roachprod` API (for starting). This change adds a new method `StartServiceForVirtualCluster` to the cluster interface to enable roachtests to start virtual clusters. Some refactoring was required to enable different sets of cluster settings, depending on what service type is going to be started. There are now two sets of cluster settings that can be utilised in `test_runner`. For virtual clusters `virtualClusterSettings` will be used, and for storage clusters `clusterSettings` will be utilised. Epic: None Release Note: None
Previously the multitenant distsql roachtest relied on an internal util in `roachtest` to start virtual clusters. This change updates the test to use the new official `roachtest` and `roachprod` APIs for starting virtual clusters. Fixes: cockroachdb#116019 Epic: None Release Note: None
Epic: None Release Note: None
Epic: None Release Note: None
Add a convenience function to return `StartOpts` for starting an external process virtual cluster. Epic: None Release Note: None
herkolategan
requested review from
DarrylWong and
renatolabs
and removed request for
a team
December 15, 2023 07:33
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
blathers-crl
bot
added
the
backport
Label PR's that are backports to older release branches
label
Dec 15, 2023
DarrylWong
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 6/6 commits from #115599.
/cc @cockroachdb/release
Previously the multitenant distsql roachtest relied on an internal util in
roachtest
to start virtual clusters. This PR updates the test to use the new officialroachtest
androachprod
APIs for starting virtual clusters.Some additional changes were required to support upgrading the test. The cluster interface only exposed a method to start storage nodes, but that is insufficient to start virtual clusters that have a separate method on the
roachprod
API (for starting).This change adds a new method
StartServiceForVirtualCluster
to the cluster interface to enable roachtests to start virtual clusters. Some refactoring was required to enable different sets of cluster settings, depending on what servicetype is going to be started.
There are now two sets of cluster settings that can be utilised in
test_runner
. For virtual clustersvirtualClusterSettings
will be used, and for storage clustersclusterSettings
will be utilised.Fixes: #116019
Release Note: None
Epic: CRDB-31933
Release justification: Test only change.