-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2: roachtest: assign adminui ports dynamically for virtual clusters #117626
release-23.2: roachtest: assign adminui ports dynamically for virtual clusters #117626
Conversation
29eb83f
to
22946ed
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
#114097 hasn't been backported yet so I think we need to set |
Thanks. I see that we backported #116525 yesterday, so we got failures today on 23.2 branch. I'll defer to you Darryl on what needs to be done to fix those. |
…e-one This test relies on assumption `adminUIPort = SQLPort + 1` but adminui is temporarily hardcoded as 26258 while SQLPort will be dynamically assigned without the following override. This changes it to discover the port instead of relying on this assumption. Release note: None
22946ed
to
1467d64
Compare
Added |
Backport 2/2 commits from #117505 on behalf of @DarrylWong.
/cc @cockroachdb/release
This was originally removed in #115599 due to #114097 merging, but adminui was reverted in #117141 and mistakenly did not revert the special case for virtual clusters. We unskip the multitenant/distsql tests as well.
Release note: None
Fixes: #117150
Fixes: #117149
Epic: None
Release justification: test-only change.