Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: port multitenant/distsql to new APIs #116019

Closed
herkolategan opened this issue Dec 11, 2023 · 1 comment · Fixed by #115599
Closed

roachtest: port multitenant/distsql to new APIs #116019

herkolategan opened this issue Dec 11, 2023 · 1 comment · Fixed by #115599
Assignees
@herkolategan
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team

Comments

@herkolategan
Copy link
Collaborator

herkolategan commented Dec 11, 2023 •
edited by cockroach-jira-scripts
Loading

See the parent issue [1] for details.

[1] #115867

Epic: CRDB-31933

Jira issue: CRDB-34384
@herkolategan herkolategan added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team labels Dec 11, 2023
@herkolategan herkolategan self-assigned this Dec 11, 2023
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Dec 11, 2023

cc @cockroachdb/test-eng

herkolategan added a commit to herkolategan/cockroach that referenced this issue Dec 11, 2023
@herkolategan
roachtest: update multitenant/distsql to use new roachprod service APIs
2a0b01d 
Previously the multitenant distsql roachtest relied on an internal util in
`roachtest` to start virtual clusters. This change updates the test to use the
new official `roachtest` and `roachprod` APIs for starting virtual clusters.

Fixes: cockroachdb#116019

Epic: None
Release Note: None
@herkolategan herkolategan mentioned this issue Dec 11, 2023
Merged
herkolategan added a commit to herkolategan/cockroach that referenced this issue Dec 12, 2023
@herkolategan
roachtest: update multitenant/distsql to use new roachprod service APIs
3d0b8c2 
Previously the multitenant distsql roachtest relied on an internal util in
`roachtest` to start virtual clusters. This change updates the test to use the
new official `roachtest` and `roachprod` APIs for starting virtual clusters.

Fixes: cockroachdb#116019

Epic: None
Release Note: None
herkolategan added a commit to herkolategan/cockroach that referenced this issue Dec 12, 2023
@herkolategan
roachtest: update multitenant/distsql to use new roachprod service APIs
d91f59c 
Previously the multitenant distsql roachtest relied on an internal util in
`roachtest` to start virtual clusters. This change updates the test to use the
new official `roachtest` and `roachprod` APIs for starting virtual clusters.

Fixes: cockroachdb#116019

Epic: None
Release Note: None
craig bot pushed a commit that referenced this issue Dec 14, 2023
@herkolategan
Merge #115599
cbcdca3 
115599: roachtest: update multitenant/distsql to use new roachprod service APIs r=renatolabs,srosenberg a=herkolategan

Previously the multitenant distsql roachtest relied on an internal util in `roachtest` to start virtual clusters. This PR updates the test to use the new official `roachtest` and `roachprod` APIs for starting virtual clusters.


Some additional changes were required to support upgrading the test. The cluster interface only exposed a method to start storage nodes, but that is insufficient to start virtual clusters that have a separate method on the `roachprod` API (for starting).

This change adds a new method `StartServiceForVirtualCluster` to the cluster interface to enable roachtests to start virtual clusters. Some refactoring was required to enable different sets of cluster settings, depending on what service
type is going to be started.

There are now two sets of cluster settings that can be utilised in `test_runner`. For virtual clusters `virtualClusterSettings` will be used, and for storage clusters `clusterSettings` will be utilised.

Fixes: #116019

Release Note: None
Epic: CRDB-31933


Co-authored-by: Herko Lategan <[email protected]>
@craig craig bot closed this as completed in 77fee69 Dec 14, 2023
herkolategan added a commit to herkolategan/cockroach that referenced this issue Dec 15, 2023
@herkolategan
roachtest: update multitenant/distsql to use new roachprod service APIs
fd8e2f0 
Previously the multitenant distsql roachtest relied on an internal util in
`roachtest` to start virtual clusters. This change updates the test to use the
new official `roachtest` and `roachprod` APIs for starting virtual clusters.

Fixes: cockroachdb#116019

Epic: None
Release Note: None
@herkolategan herkolategan mentioned this issue Dec 15, 2023
Merged
herkolategan added a commit to herkolategan/cockroach that referenced this issue Dec 15, 2023
@herkolategan
roachtest: update multitenant/distsql to use new roachprod service APIs
70ae899 
Previously the multitenant distsql roachtest relied on an internal util in
`roachtest` to start virtual clusters. This change updates the test to use the
new official `roachtest` and `roachprod` APIs for starting virtual clusters.

Fixes: cockroachdb#116019

Epic: None
Release Note: None
@herkolategan herkolategan mentioned this issue Dec 15, 2023
Merged
DarrylWong pushed a commit to DarrylWong/fork that referenced this issue Jan 16, 2024
@herkolategan @DarrylWong
roachtest: update multitenant/distsql to use new roachprod service APIs
040a6f4 
Previously the multitenant distsql roachtest relied on an internal util in
`roachtest` to start virtual clusters. This change updates the test to use the
new official `roachtest` and `roachprod` APIs for starting virtual clusters.

Fixes: cockroachdb#116019

Epic: None
Release Note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@herkolategan herkolategan

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team
Projects
No open projects
Test Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

roachtest: update multitenant/distsql to use new roachprod service APIs herkolategan/cockroach
1 participant
@herkolategan