roachtest: port multitenant tests to new roachprod APIs #115867
Labels
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
meta-issue
Contains a list of several other issues.
T-testeng
TestEng Team
Comments
herkolategan
added
C-enhancement
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
cc @cockroachdb/test-eng |
This was referenced Dec 8, 2023
This was referenced Jan 11, 2024
herkolategan
added a commit
to herkolategan/cockroach
that referenced
this issue
Mar 14, 2024
Previously, `multitenant_utils.go` provided convenience functions to start virtual clusters. These utils served as a good interim, but lacked proper integration with roachprod and the cluster interfaces. After the introduction of virtual cluster APIs in roachprod and roachtest those interfaces should rather be used from now on. The functions exposed in `multitenant_utils.go` have been prefixed with deprecated, and given added docs to discourage any further use and point future implementations to the new API. See: cockroachdb#115867 Epic: None Release Note: None
craig bot
pushed a commit
that referenced
this issue
Mar 18, 2024
120480: roachtest: deprecate multitenant_utils r=DarrylWong a=herkolategan Previously, `multitenant_utils.go` provided convenience functions to start virtual clusters. These utils served as a good interim, but lacked proper integration with roachprod and the cluster interfaces. After the introduction of virtual cluster APIs in roachprod and roachtest those interfaces should rather be used from now on. The functions exposed in `multitenant_utils.go` have been prefixed with deprecated, and given added docs to discourage any further use and point future implementations to the new API. See: #115867 Epic: None Release Note: None 120631: pcr: quantize PCR frontier timestamps to 5s r=dt a=dt Fewer distinct timestamps makes it easier to merge adjacent spans. Release note: none. Epic: none. 120632: pcr: use the bulk oracle r=dt a=dt Release note: none. Epic: none. Co-authored-by: Herko Lategan <[email protected]> Co-authored-by: David Taylor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After a series of PRs that enable
roachprodto start and manage virtual clusters on various ports using DNS and services, we can now start porting tests that used a temporary collection of multitenant utilities inroachtestto do testing with virtual clusters.This is an example PR of a recent conversion: #115599
That can serve as a guideline for converting the rest of the tests. There might still be small bits of functionality required or new methods that need to be added to the API that can be implemented as part of the conversion issue (or new issue if preferred).
Epic: CRDB-31933
Jira issue: CRDB-34260
The text was updated successfully, but these errors were encountered: