Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: port acceptance/multitenant to new APIs #117671

Closed
herkolategan opened this issue Jan 11, 2024 · 1 comment · Fixed by #119598
Closed

roachtest: port acceptance/multitenant to new APIs #117671

herkolategan opened this issue Jan 11, 2024 · 1 comment · Fixed by #119598
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team

Comments

@herkolategan
Copy link
Collaborator

herkolategan commented Jan 11, 2024

See the parent issue [1] for details.
Test location: pkg/cmd/roachtest/tests/multitenant.go

[1] #115867

Epic: CRDB-31933

Jira issue: CRDB-35297

@herkolategan herkolategan added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team labels Jan 11, 2024
Copy link

blathers-crl bot commented Jan 11, 2024

cc @cockroachdb/test-eng

renatolabs added a commit to renatolabs/cockroach that referenced this issue Feb 23, 2024
This commit updates the `acceptance/multitenant` roachtest to use the
recently introduced roachprod API to manage virtual clusters.

It also removes the previous log checking, as that logic is
brittle. In addition, we no longer support creating virtual clusters
by ID. The acceptance test just verifies that we are able to create a
new virtual cluster, perform basic queries on it, and terminate it.

Fixes: cockroachdb#117671.

Release note: None
craig bot pushed a commit that referenced this issue Feb 27, 2024
119598: roachtest: acceptance/multitenant uses virtual cluster roachprod API  r=srosenberg a=renatolabs

This commit updates the `acceptance/multitenant` roachtest to use the
recently introduced roachprod API to manage virtual clusters.

It also removes the previous log checking, as that logic is
brittle. In addition, we no longer support creating virtual clusters
by ID. The acceptance test just verifies that we are able to create a
new virtual cluster, perform basic queries on it, and terminate it.

Fixes: #117671.

Release note: None

119697: workflows: use new version of certificate r=rail a=rickystewart

Epic: CRDB-8308
Release note: None

Co-authored-by: Renato Costa <[email protected]>
Co-authored-by: Ricky Stewart <[email protected]>
@craig craig bot closed this as completed in b7beb71 Feb 27, 2024
cockroach-dev-inf pushed a commit that referenced this issue Feb 28, 2024
This commit updates the `acceptance/multitenant` roachtest to use the
recently introduced roachprod API to manage virtual clusters.

It also removes the previous log checking, as that logic is
brittle. In addition, we no longer support creating virtual clusters
by ID. The acceptance test just verifies that we are able to create a
new virtual cluster, perform basic queries on it, and terminate it.

Fixes: #117671.

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant