Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.2.0-rc: sql: omit virtual tables from stmt bundles #115847

Merged
merged 1 commit into from
Dec 12, 2023
Merged

release-23.2.0-rc: sql: omit virtual tables from stmt bundles #115847

merged 1 commit into from
Dec 12, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Dec 8, 2023 •
edited by yuzefovich
Loading

Backport 1/1 commits from #115817 on behalf of @yuzefovich.

/cc @cockroachdb/release

This commit makes it so that we do not include virtual tables into schema.sql file (as well as don't create the stats files for them) into the stmt bundle. This should make it easier to recreate the bundles that access virtual tables.

Note that in the future, once we support stats on virtual tables, this logic will need to be update so that only the create statements are omitted.

Fixes: #115437.

Release note: None

Release justification: low-risk debugging improvement.

@yuzefovich
sql: omit virtual tables from stmt bundles
c9471df 
This commit makes it so that we do not include virtual tables into
`schema.sql` file (as well as don't create the stats files for them)
into the stmt bundle. This should make it easier to recreate the bundles
that access virtual tables.

Note that in the future, once we support stats on virtual tables, this
logic will need to be update so that only the create statements are
omitted.

Release note: None
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2.0-rc-115817 branch from 6875b70 to c9471df Compare December 8, 2023 01:35
@blathers-crl blathers-crl bot requested a review from a team as a code owner December 8, 2023 01:35
@blathers-crl blathers-crl bot requested review from DrewKimball and removed request for a team December 8, 2023 01:35
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Dec 8, 2023
@blathers-crl blathers[crl]
Copy link
Author

blathers-crl bot commented Dec 8, 2023 •
edited by yuzefovich
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot requested review from michae2, rytaft, yuzefovich and a team December 8, 2023 01:35
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Dec 8, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@yuzefovich yuzefovich requested review from mgartner and removed request for DrewKimball December 8, 2023 01:44
rytaft
rytaft approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @mgartner, @michae2, and @yuzefovich)

@yuzefovich yuzefovich merged commit 434fb05 into release-23.2.0-rc Dec 12, 2023
5 of 6 checks passed
@yuzefovich yuzefovich deleted the blathers/backport-release-23.2.0-rc-115817 branch December 12, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rytaft rytaft rytaft approved these changes

@michae2 michae2 Awaiting requested review from michae2

@yuzefovich yuzefovich Awaiting requested review from yuzefovich

@mgartner mgartner Awaiting requested review from mgartner

Assignees

@yuzefovich yuzefovich

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @rytaft @yuzefovich