sql: omit virtual tables from stmt bundles #115817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes it so that we do not include virtual tables into `schema.sql` file (as well as don't create the stats files for them) into the stmt bundle. This should make it easier to recreate the bundles that access virtual tables. Note that in the future, once we support stats on virtual tables, this logic will need to be update so that only the create statements are omitted. Release note: None
yuzefovich
added
backport-23.1.x
|
This change is |
rytaft
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @michae2)
|
Build succeeded: |
This was referenced Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes it so that we do not include virtual tables into
schema.sqlfile (as well as don't create the stats files for them) into the stmt bundle. This should make it easier to recreate the bundles that access virtual tables.Note that in the future, once we support stats on virtual tables, this logic will need to be update so that only the create statements are omitted.
Fixes: #115437.
Release note: None