Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stmtbundle: do not include virtual tables and its stats #115437

Closed
yuzefovich opened this issue Dec 1, 2023 · 0 comments · Fixed by #115817
Closed

stmtbundle: do not include virtual tables and its stats #115437

yuzefovich opened this issue Dec 1, 2023 · 0 comments · Fixed by #115817
Assignees
@yuzefovich
Labels
A-sql-debug-bundle Issues related to statement bundle improvements C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. E-quick-win Likely to be a quick win for someone experienced. O-support Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs T-sql-queries SQL Queries Team

Comments

@yuzefovich
Copy link
Member

yuzefovich commented Dec 1, 2023 •
edited by cockroach-jira-scripts
Loading

Currently, when we get a bundle for query that touches virtual tables (e.g. EXPLAIN ANALYZE (DEBUG) SELECT count(*) FROM pg_catalog.pg_class;), the bundle will include the schema of the virtual table in schema.sql as well as absent table stats (we currently don't support stats for virtual tables). Both of these things break debug statement-bundle recreate command, so we should omit them from the bundle. Once stats on virtual tables are supported (tracked by #27611), we should add the stats back.

Jira issue: CRDB-34035
@yuzefovich yuzefovich added C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. T-sql-queries SQL Queries Team E-quick-win Likely to be a quick win for someone experienced. A-sql-debug-bundle Issues related to statement bundle improvements labels Dec 1, 2023
@yuzefovich yuzefovich self-assigned this Dec 1, 2023
@yuzefovich yuzefovich added the O-support Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs label Dec 1, 2023
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries Dec 1, 2023
@yuzefovich yuzefovich moved this from Triage to Active in SQL Queries Dec 1, 2023
@yuzefovich yuzefovich mentioned this issue Dec 7, 2023
Merged
@craig craig bot closed this as completed in 37ad01a Dec 8, 2023
@github-project-automation github-project-automation bot moved this from Active to Done in SQL Queries Dec 8, 2023
This was referenced Dec 8, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuzefovich yuzefovich

Labels
A-sql-debug-bundle Issues related to statement bundle improvements C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. E-quick-win Likely to be a quick win for someone experienced. O-support Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: omit virtual tables from stmt bundles yuzefovich/cockroach
1 participant
@yuzefovich