Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2: storage: add cluster setting for ingest splits #115642

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Dec 5, 2023

Backport 1/1 commits from #115462 on behalf of @itsbilal.

/cc @cockroachdb/release


Previously, the ingest-time splitting feature was only tunable through a code change. This change adds a cluster setting to allow this feature to be turned on dynamically.

Fixes #115430.

Epic: none

Release note: None


Release justification: low-risk addition of a cluster setting to be able to toggle a new, experimental feature.

@blathers-crl blathers-crl bot requested a review from a team as a code owner December 5, 2023 20:30
@blathers-crl blathers-crl bot requested a review from jbowens December 5, 2023 20:30
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-115462 branch from 5c88f44 to 1ce92f5 Compare December 5, 2023 20:30
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Dec 5, 2023
Copy link
Author

blathers-crl bot commented Dec 5, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot requested a review from RaduBerinde December 5, 2023 20:30
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Dec 5, 2023
Copy link
Author

blathers-crl bot commented Dec 5, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @blathers-crl[bot] and @RaduBerinde)


pkg/storage/pebble.go line 140 at r1 (raw file):

	"set to true to use ingest-time splitting to lower write-amplification (experimental)",
	util.ConstantWithMetamorphicTestBool(
		"storage.ingest_split.enabled", false), /* defaultValue */

I am wary of enabling this metamorphically on the release-23.2 branch before there's been any baking on master, especially given we're not yet at a release candidate.

@nicktrav nicktrav added GA-blocker branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 labels Dec 6, 2023
@nicktrav
Copy link
Collaborator

nicktrav commented Dec 6, 2023

+1 to @jbowens's comment. Perhaps we enable metamorphically on master for now? Or do we just want to go all in and enable by default on master?

Otherwise EM LGTM ✅

Previously, the ingest-time splitting feature was only
tunable through a code change. This change adds a cluster
setting to allow this feature to be turned on dynamically.

Fixes #115430.

Epic: none

Release note: None

Release justification: low-risk addition of a cluster setting to
be able to toggle a new, experimental feature.
@itsbilal itsbilal force-pushed the blathers/backport-release-23.2-115462 branch from 1ce92f5 to 6091349 Compare December 6, 2023 15:41
@itsbilal itsbilal requested a review from jbowens December 6, 2023 15:43
Copy link
Member

@itsbilal itsbilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTR!

We can roll in the default value true change into #115432 probably? Should be easy to have one PR that just changes the defaults to true for three cluster settings.

Reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @jbowens and @RaduBerinde)


pkg/storage/pebble.go line 140 at r1 (raw file):

Previously, jbowens (Jackson Owens) wrote…

I am wary of enabling this metamorphically on the release-23.2 branch before there's been any baking on master, especially given we're not yet at a release candidate.

Done.

Copy link
Collaborator

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@itsbilal itsbilal merged commit ae42927 into release-23.2 Dec 6, 2023
5 of 6 checks passed
@itsbilal itsbilal deleted the blathers/backport-release-23.2-115462 branch December 6, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 GA-blocker O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants