storage: allow setting IngestSplit #115430
Assignees
Labels
A-storage
Relating to our storage engine (Pebble) on-disk storage.
branch-release-23.2
Used to mark GA and release blockers, technical advisories, and bugs for 23.2
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
GA-blocker
T-storage
Storage Team
Comments
nicktrav
added
C-enhancement
|
Adding GA blocker label, as we should have this for 23.2. |
nicktrav
added
GA-blocker
branch-release-23.2
craig bot
pushed a commit
that referenced
this issue
Dec 5, 2023
115447: roachtest: indicate when version is too old in `UploadWorkload` r=DarrylWong,srosenberg a=renatolabs In #115061, a `UploadWorkload` API was added to allow tests to upload "arbitrary" versions of the `workload` binary, especially useful in upgrade testing. However, we only have `workload` binaries for v22.2+. In this commit, we add a `bool` return value to `UplodWorkload` indicating whether a binary was actually uploaded. Callers are expected to check this value before attempting to use a workload binary. The `acceptance/version-upgrade` test is updated in this commit in the way described. Epic: none Release note: None 115462: storage: add cluster setting for ingest splits r=RaduBerinde a=itsbilal Previously, the ingest-time splitting feature was only tunable through a code change. This change adds a cluster setting to allow this feature to be turned on dynamically. Fixes #115430. Epic: none Release note: None 115593: ui: change some references to tenant to virtual cluster r=dhartunian a=stevendanna This changes the "Tenant" selector on the metrics pages to use the new "Virtual Cluster" terminology. Fixes #114170 Release note: None <img width="1037" alt="Screenshot 2023-12-05 at 11 05 10" src="https://github.com/cockroachdb/cockroach/assets/852371/54f9ce9c-fc0b-4457-8214-de22c45b32bc"> <img width="1086" alt="Screenshot 2023-12-05 at 11 05 05" src="https://github.com/cockroachdb/cockroach/assets/852371/d0cb2f32-20a6-4522-8727-3c19ce0a91ab"> 115595: server: support strict MemFS in StickyVFSRegistry r=jbowens a=pavelkalinnikov The strict `MemFS` can be used for emulating crashes, and testing for data durability loss that they may cause if fsync is not used correctly. Touches #113135, #114411 Epic: none Release note: none Co-authored-by: Renato Costa <[email protected]> Co-authored-by: Bilal Akhtar <[email protected]> Co-authored-by: Steven Danna <[email protected]> Co-authored-by: Pavel Kalinnikov <[email protected]>
blathers-crl bot
pushed a commit
that referenced
this issue
Dec 5, 2023
Previously, the ingest-time splitting feature was only tunable through a code change. This change adds a cluster setting to allow this feature to be turned on dynamically. Fixes #115430. Epic: none Release note: None
itsbilal
added a commit
that referenced
this issue
Dec 6, 2023
Previously, the ingest-time splitting feature was only tunable through a code change. This change adds a cluster setting to allow this feature to be turned on dynamically. Fixes #115430. Epic: none Release note: None Release justification: low-risk addition of a cluster setting to be able to toggle a new, experimental feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Pebble now has support for virtualizing tables on ingest. This is currently controlled via a Pebble configuration option,
IngestSplit, defaulting tofalse.Enable dynamically altering this param, via a cluster setting, so that it can be trialled on 23.2 clusters.
We should also default to
trueonmaster.Jira issue: CRDB-34030
The text was updated successfully, but these errors were encountered: