Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: enable excise-on-snapshot and EFOS by default #115432

Closed
nicktrav opened this issue Dec 1, 2023 · 0 comments · Fixed by #117116
Closed

storage: enable excise-on-snapshot and EFOS by default #115432

nicktrav opened this issue Dec 1, 2023 · 0 comments · Fixed by #117116
Assignees
Labels
A-storage Relating to our storage engine (Pebble) on-disk storage. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-storage Storage Team

Comments

@nicktrav
Copy link
Collaborator

nicktrav commented Dec 1, 2023

We have two cluster settings:

  • storage.experimental.eventually_file_only_snapshots.enabled,
  • kv.snapshot_receiver.excise.enabled,
  • storage.ingest_split.enabled.

All are disabled by default in 23.2.

Change the defaults to true on master.

Jira issue: CRDB-34032

@nicktrav nicktrav added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-storage Relating to our storage engine (Pebble) on-disk storage. T-storage Storage Team labels Dec 1, 2023
@nicktrav nicktrav self-assigned this Dec 12, 2023
nicktrav added a commit to nicktrav/cockroach that referenced this issue Dec 13, 2023
The following three cluster settings were introduced in the 23.2 cycle,
and are disabled by default in that release:

- `storage.experimental.eventually_file_only_snapshots.enabled`,
- `kv.snapshot_receiver.excise.enabled`,
- `storage.ingest_split.enabled`.

Enable all three by default, in preparation for 24.1.

Fixes cockroachdb#115432.

Release note: None.
nicktrav added a commit to nicktrav/cockroach that referenced this issue Dec 18, 2023
The following three cluster settings were introduced in the 23.2 cycle,
and are disabled by default in that release:

- `storage.experimental.eventually_file_only_snapshots.enabled`,
- `kv.snapshot_receiver.excise.enabled`,
- `storage.ingest_split.enabled`.

Enable all three by default, in preparation for 24.1.

Fixes cockroachdb#115432.

Release note: None.
craig bot pushed a commit that referenced this issue Dec 27, 2023
117116: pkg/storage: enable EFOS, excise on snapshot, ingest splitting r=nicktrav a=itsbilal

The following three cluster settings were introduced in the 23.2 cycle, and are disabled by default in that release:

- `storage.experimental.eventually_file_only_snapshots.enabled`,
- `kv.snapshot_receiver.excise.enabled`,
- `storage.ingest_split.enabled`.

Enable all three by default, in preparation for 24.1.

Fixes #115432.

Release note: None.

Co-authored-by: Nick Travers <[email protected]>
@craig craig bot closed this as completed in 945b21b Dec 27, 2023
@jbowens jbowens moved this to Done in [Deprecated] Storage Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-storage Relating to our storage engine (Pebble) on-disk storage. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-storage Storage Team
Projects
Archived in project
1 participant