Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamingccl: reduce scan interval for testing #112735

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

kvoli
Copy link
Collaborator

@kvoli kvoli commented Oct 19, 2023

Reduce the replica scanner min interval from 1s, to 10ms for test
clusters. This speeds up tests which rely on replica changes either on
the source, or host cluster.

dev test pkg/ccl/streamingccl/streamingest \
  -f TestStreamingRegionalConstraint -v --stress
...
Stats over 1000 runs: max = 51.9s, min = 21.6s, avg = 38.3s, dev = 4.6s

Resolves: #112541
Release note: None

@kvoli kvoli self-assigned this Oct 19, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@kvoli kvoli force-pushed the 231019.c2c-deflake branch from 2dc1de8 to 25192da Compare October 20, 2023 00:14
@kvoli
Copy link
Collaborator Author

kvoli commented Oct 20, 2023

CI failure looks unrelated.

@kvoli kvoli marked this pull request as ready for review October 20, 2023 01:31
@kvoli kvoli requested a review from a team as a code owner October 20, 2023 01:31
@kvoli kvoli requested review from msbutler and removed request for a team October 20, 2023 01:31
@kvoli
Copy link
Collaborator Author

kvoli commented Oct 20, 2023

Failure is known issue #111481

@kvoli kvoli added the backport-23.2.x Flags PRs that need to be backported to 23.2. label Oct 20, 2023
Reduce the replica scanner min interval from 1s, to 10ms for test
clusters. This speeds up tests which rely on replica changes either on
the source, or host cluster.

```
dev test pkg/ccl/streamingccl/streamingest \
  -f TestStreamingRegionalConstraint -v --stress
...
Stats over 1000 runs: max = 51.9s, min = 21.6s, avg = 38.3s, dev = 4.6s
```

Resolves: cockroachdb#112541
Release note: None
@kvoli kvoli force-pushed the 231019.c2c-deflake branch from 25192da to 08959eb Compare October 20, 2023 20:19
@kvoli
Copy link
Collaborator Author

kvoli commented Oct 20, 2023

rebased

@kvoli
Copy link
Collaborator Author

kvoli commented Oct 23, 2023

TYFTR

bors r=msbutler

@craig
Copy link
Contributor

craig bot commented Oct 23, 2023

Build succeeded:

@craig craig bot merged commit 9594bba into cockroachdb:master Oct 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.2.x Flags PRs that need to be backported to 23.2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

streamingccl: TestStreamingRegionalConstraint times out under stress due to allocator cpu starvation
3 participants