Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.2: streamingccl: reduce scan interval for testing #112853

Merged
merged 1 commit into from
Oct 24, 2023
Merged

release-23.2: streamingccl: reduce scan interval for testing #112853

merged 1 commit into from
Oct 24, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Oct 23, 2023 •
edited by kvoli
Loading

Backport 1/1 commits from #112735 on behalf of @kvoli.

/cc @cockroachdb/release

Reduce the replica scanner min interval from 1s, to 10ms for test
clusters. This speeds up tests which rely on replica changes either on
the source, or host cluster.

dev test pkg/ccl/streamingccl/streamingest \
  -f TestStreamingRegionalConstraint -v --stress
...
Stats over 1000 runs: max = 51.9s, min = 21.6s, avg = 38.3s, dev = 4.6s

Resolves: #112541
Release note: None

Release justification: Test only.

@blathers-crl blathers-crl bot requested a review from a team as a code owner October 23, 2023 13:02
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-112735 branch from dc24db6 to 86d49e5 Compare October 23, 2023 13:02
@blathers-crl blathers-crl bot requested review from msbutler and removed request for a team October 23, 2023 13:02
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-112735 branch from df10279 to 25c44ac Compare October 23, 2023 13:02
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 23, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Oct 23, 2023 •
edited by kvoli
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Oct 23, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

msbutler
msbutler reviewed Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@msbutler msbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Mind unskipping the test line 1172, and bumping the checkLocalities timeouts to 3 min 45 seconds so the 23.2 test reflects whats on master?

@kvoli
Copy link
Collaborator

kvoli commented Oct 23, 2023

Thanks for doing this! Mind unskipping the test line 1172, and bumping the checkLocalities timeouts to 3 min 45 seconds so the 23.2 test reflects whats on master?

I think we should backport and merge those commits from master, rather than pushing them in this commit.

@msbutler
Copy link
Collaborator

works for me

@kvoli
streamingccl: reduce scan interval for testing
8dd448d 
Reduce the replica scanner min interval from 1s, to 10ms for test
clusters. This speeds up tests which rely on replica changes either on
the source, or host cluster.

```
dev test pkg/ccl/streamingccl/streamingest \
  -f TestStreamingRegionalConstraint -v --stress
...
Stats over 1000 runs: max = 51.9s, min = 21.6s, avg = 38.3s, dev = 4.6s
```

Resolves: #112541
Release note: None
@kvoli
Copy link
Collaborator

kvoli commented Oct 23, 2023

Rebased.

@kvoli kvoli force-pushed the blathers/backport-release-23.2-112735 branch from 25c44ac to 8dd448d Compare October 23, 2023 23:17
@msbutler
Copy link
Collaborator

cherry-picked this locally on 23.2 and confirmed the test builds and passes. merging.

@msbutler msbutler merged commit af2cdce into release-23.2 Oct 24, 2023
2 checks passed
@msbutler msbutler deleted the blathers/backport-release-23.2-112735 branch October 24, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msbutler msbutler msbutler approved these changes

Assignees

@kvoli kvoli

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @kvoli @msbutler