Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamingccl: reduce scan interval for testing #112735

Merged
merged 1 commit into from
Oct 23, 2023
+3 −2
Merged

streamingccl: reduce scan interval for testing #112735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/ccl/streamingccl/replicationtestutils/testutils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,7 @@ func startC2CTestCluster(
for i, locality := range regions {
param := serverArgs
param.Locality = makeLocality(locality)
param.ScanMaxIdleTime = 10 * time.Millisecond
serverArgsPerNode[i] = param
}
params.ServerArgsPerNode = serverArgsPerNode
Expand Down
4 changes: 2 additions & 2 deletions pkg/ccl/streamingccl/streamingest/replication_stream_e2e_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1170,7 +1170,6 @@ func TestStreamingRegionalConstraint(t *testing.T) {
defer leaktest.AfterTest(t)()
defer log.Scope(t).Close(t)
skip.UnderStressRace(t, "takes too long under stress race")
skip.UnderStress(t, "the allocator machinery stuggles with cpu contention, which can cause the test to timeout")

ctx := context.Background()
regions := []string{"mars", "venus", "mercury"}
Expand Down Expand Up @@ -1204,7 +1203,8 @@ func TestStreamingRegionalConstraint(t *testing.T) {
for _, desc := range descriptors {
for _, replica := range desc.InternalReplicas {
if replica.NodeID != marsNodeID {
return errors.Newf("found table data located on another node %d", replica.NodeID)
return errors.Newf("found table data located on another node %d, desc %v",
replica.NodeID, desc)
}
}
}
Expand Down
Loading