Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: add latency info to explain plan tab #107719

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

maryliag
Copy link
Contributor

This commit adds columns for latency information
(p50, p90, p99, pMax, pMin) on Explain Plan tab under Statement Details page.

Fixes #105371

Screenshot 2023-07-27 at 10 59 41 AM

Release note (ui change): Add columns for p50, p90, p99 percentiles and latency min and max on Explain Plan tab on Statement Details page.

This commit adds columns for latency information
(p50, p90, p99, pMax, pMin) on Explain Plan tab under
Statement Details page.

Fixes cockroachdb#105371

Release note (ui change): Add columns for p50, p90, p99 percentiles
and latency min and max on Explain Plan tab on Statement Details
page.
@maryliag maryliag requested review from a team July 27, 2023 15:00
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@j82w j82w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@maryliag
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Jul 28, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jul 28, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jul 28, 2023

Build succeeded:

@craig craig bot merged commit c986d84 into cockroachdb:master Jul 28, 2023
@maryliag maryliag deleted the percentile-explain branch July 28, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: Explain plan show P90, P95, P99
3 participants