Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Explain plan show P90, P95, P99 #105371

Closed
j82w opened this issue Jun 22, 2023 · 1 comment · Fixed by #107719
Closed

ui: Explain plan show P90, P95, P99 #105371

j82w opened this issue Jun 22, 2023 · 1 comment · Fixed by #107719
Assignees
@maryliag
Labels
A-cluster-observability Related to cluster observability C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@j82w
Copy link
Contributor

j82w commented Jun 22, 2023 •
edited by cockroach-jira-scripts
Loading

The explain plan should show the P90, P95, P99 per a plan. The information should be available in the statistics table already. This is needed to better help understand the latency difference between plans.

Screenshot 2023-06-22 at 2 20 22 PM

Jira issue: CRDB-29003
@j82w j82w added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-cluster-observability A-cluster-observability Related to cluster observability labels Jun 22, 2023
@RoachietheSupportRoach
Copy link
Collaborator

Zendesk ticket #17474 has been linked to this issue.

@maryliag maryliag self-assigned this Jul 27, 2023
@maryliag maryliag mentioned this issue Jul 27, 2023
Merged
craig bot pushed a commit that referenced this issue Jul 28, 2023
@DrewKimball @maryliag @yuzefovich
Merge #105552 #107719 #107732
c986d84 
105552: multitenant: deflake TestConsumption r=yuzefovich a=DrewKimball

This patch adds retries to the `TestConsumption` test for retrieving the total tenant RU consumption in order to ensure that the delta includes the bucket flush that was triggered by the test query, instead of background activity.


Fixes #94286
Fixes #106572

Release note: None

107719: ui: add latency info to explain plan tab r=maryliag a=maryliag

This commit adds columns for latency information
(p50, p90, p99, pMax, pMin) on Explain Plan tab under Statement Details page.

Fixes #105371

<img width="1707" alt="Screenshot 2023-07-27 at 10 59 41 AM" src="https://github.com/cockroachdb/cockroach/assets/1017486/81a2ce3d-655e-47c1-931b-00e34433b3a1">


Release note (ui change): Add columns for p50, p90, p99 percentiles and latency min and max on Explain Plan tab on Statement Details page.

107732: valueside: use redact type name when can't decode r=yuzefovich a=yuzefovich

Informs: #106158
Epic: None

Release note: None

Co-authored-by: Drew Kimball <[email protected]>
Co-authored-by: maryliag <[email protected]>
Co-authored-by: Yahor Yuzefovich <[email protected]>
@craig craig bot closed this as completed in 11acdea Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryliag maryliag

Labels
A-cluster-observability Related to cluster observability C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: add latency info to explain plan tab maryliag/cockroach
3 participants
@maryliag @j82w @RoachietheSupportRoach