Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #107719 - ui: add latency info to explain plan tab #17580

Closed
cockroach-teamcity opened this issue Jul 29, 2023 · 3 comments
Closed

PR #107719 - ui: add latency info to explain plan tab #17580

cockroach-teamcity opened this issue Jul 29, 2023 · 3 comments

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jul 29, 2023

Exalate commented:

Related PR: cockroachdb/cockroach#107719
Commit: cockroachdb/cockroach@11acdea
Fixes: CRDB-29003


Release note (ui change): Add columns for p50, p90, p99 percentiles
and latency min and max on Explain Plan tab on Statement Details
page.

Jira Issue: DOC-8446

@exalate-issue-sync
Copy link

Kevin Ngo (kevin-v-ngo) commented:
Add sampling strategy as well for each columns and how the P90s are computed.

Copy link

Florence Morris (florence-crl) commented:
{quote}Add sampling strategy as well for each columns and how the P90s are computed.{quote}

Marylia Gutierrezwould you be able to provide more detail about sampling strategy or how the percentiles are computed?

Copy link

Marylia Gutierrez (maryliag) commented:
We didn’t go into much level of details into the sampling because it’s a little obscure for the user, is from an internal system also used by Insights, so it would be a little hard to explain to the user, so this is why we decided even on the tooltip to just say sampled.
If you want more details, we decide the sample on events that were detected by Insights, so only events part of Insights are sampled.

Now on to how percentiles are computed, there is nothing different here, is just how any other percentile is calculated. We get the values for all the ones we sampled and then calculate the percentiles based on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants