jobs: enable downloading execution detail files

[adityamaru]

In #106879 we added a table to the Advanced Debugging
tab of the job details page. This table lists out all
the execution detail files that are available for the
given job.

This change is a follow up to add download functionality
to each row in the table. The format of the downloaded
file is determined by the prefix of the filename.

A final change to allow users to generate execution details
will be added in the next follow up.

Informs: #105076
Release note: None

[cockroach-teamcity]

This change is 

[adityamaru]

https://www.loom.com/share/c89895f44e41462594a22dcd8f72caf0?sid=afc4447c-97e4-4f30-9829-33445aa4f669

[adityamaru]

first commit is from #107198 so only second commit needs a review here!

[adityamaru]

@maryliag based on your offline chat I tried to add a space between Download and the icon but I can't seem to figure it out 🤦 . I looked if statement bundles do anything but they seem to also have the same button/icon layout as in the loom.

[adityamaru]

oh I might have figured it out, pushing something.

[adityamaru]

here we go!

[maryliag]

Nice! Thanks for also updating name of function to clarify is about files.
I will leave to somebody on your team to review the first commit, since I don't know enough to make sure is covering everything, so my review is focused on the ui changes only, which is the second commit

For that I added a few nits, otherwise

Reviewed 6 of 6 files at r1, 9 of 12 files at r2.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @adityamaru and @dt)

---

pkg/ui/workspaces/cluster-ui/src/jobs/jobDetailsPage/jobProfilerView.tsx line 17 at r2 (raw file):

import { Button, InlineAlert, Icon } from "@cockroachlabs/ui-components";
import { Row, Col } from "antd";
import "antd/lib/icon/style";

curious, where you getting lint error if you didn't add those? Asking because you just need to import the style when the import was the "antd". The Button and Icon were not, so there is no need

---

pkg/ui/workspaces/cluster-ui/src/jobs/jobDetailsPage/jobProfilerView.module.scss line 5 at r2 (raw file):

.crl-job-profiler-view {
    display: flex;
    flex-direction: column;

I don't see you using crl-job-profiler-view anywhere, just crl-job-profiler-view__actions-column, so these tow lines are not being used anywhere

[blathers-crl]

Thank you for updating your pull request.

Before a member of our team reviews your PR, I have some potential action items for you:

• We notice you have more than one commit in your PR. We try break logical changes into separate commits, but commits such as "fix typo" or "address review commits" should be squashed into one commit and pushed with --force
• When CI has completed, please ensure no errors have appeared.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

[adityamaru]

Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @dt and @maryliag)

---

pkg/ui/workspaces/cluster-ui/src/jobs/jobDetailsPage/jobProfilerView.tsx line 17 at r2 (raw file):

Previously, maryliag (Marylia Gutierrez) wrote…

curious, where you getting lint error if you didn't add those? Asking because you just need to import the style when the import was the "antd". The Button and Icon were not, so there is no need

Done.

---

pkg/ui/workspaces/cluster-ui/src/jobs/jobDetailsPage/jobProfilerView.module.scss line 5 at r2 (raw file):

Previously, maryliag (Marylia Gutierrez) wrote…

I don't see you using crl-job-profiler-view anywhere, just crl-job-profiler-view__actions-column, so these tow lines are not being used anywhere

Done.

[adityamaru]

Now that this is rebased, I'm going to merge this UI only change.

TFTR!

bors r=maryliag

[craig]

Build failed (retrying...):

• Bazel Essential CI (Cockroach)

[craig]

This PR was included in a batch that timed out, it will be automatically retried

[adityamaru]

bors retry

[craig]

Already running a review

[craig]

Build failed (retrying...):

• Bazel Essential CI (Cockroach)

[craig]

Build succeeded:

• Bazel Essential CI (Cockroach)