jobsprofiler: stringify protobin files when requested #107198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
adityamaru
force-pushed
the
on-the-fly-stringify
branch
from
64f48f9 to
514221c
Compare
|
CI failures are all unrelated |
adityamaru
force-pushed
the
on-the-fly-stringify
branch
from
514221c to
e8585a6
Compare
dt
reviewed
Jul 25, 2023
adityamaru
force-pushed
the
on-the-fly-stringify
branch
4 times, most recently
from
6fb5381 to
e55a66e
Compare
This change is in preparation for a larger change that will allow downloading debug files from the `Advanded Debugging` tab on the job details page. With this change a `binpb` file will have a `binpb.txt` version of the file listed too. If the user requests to download a `binpb.txt` file we unmarshal and stringify the contents of the file before serving them to the user. Currently, there is only one protobin file type written by a job resumer on completion. Release note: None
adityamaru
force-pushed
the
on-the-fly-stringify
branch
from
e55a66e to
b4362a6
Compare
|
CI failure is being tracked in #107669 |
dt
approved these changes
Jul 27, 2023
|
TFTR! bors r=dt |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is in preparation for a larger change that
will allow downloading debug files from the
Advanded Debuggingtab on the job details page.
With this change a
binpbfile will have abinpb.txtversion of thefile listed too. If the user requests to download
a
binpb.txtfile we unmarshal and stringify the contentsof the file before serving them to the user. Currently, there
is only one protobin file type written by a job resumer on
completion.
Informs: #105076
Release note: None