Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: collect cluster-wide traces as part of job execution details #107114

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

adityamaru
Copy link
Contributor

@adityamaru adityamaru commented Jul 18, 2023

This change includes the collection of cluster-wide, active tracing
spans to a job's execution details. The traces are stored in a zip
with a text and jaegar json file per node, that contain the active
tracing spans associated with the current execution of the job.

Once #106879
and #107210
merge a trace.zip will be generated everytime a user requests
new execution details from the job details page. This zip will
be downloadable from the job details page itself.

Informs: #102794
Release note: None

@adityamaru adityamaru requested review from dt and stevendanna July 18, 2023 20:16
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Looks like we have an existing test to update.

Also, it might be good to put an example of how to use these improvements in the commit message/PR message so it is easier to play with.

pkg/sql/jobs_profiler_execution_details.go Outdated Show resolved Hide resolved
pkg/sql/jobs_profiler_execution_details.go Outdated Show resolved Hide resolved
pkg/sql/jobs_profiler_execution_details_test.go Outdated Show resolved Hide resolved
pkg/sql/jobs_profiler_execution_details_test.go Outdated Show resolved Hide resolved
pkg/sql/jobs_profiler_execution_details.go Outdated Show resolved Hide resolved
@adityamaru adityamaru force-pushed the clusterwide-profile branch from c9835e7 to e78fb2f Compare July 19, 2023 21:56
@adityamaru adityamaru requested review from a team as code owners July 19, 2023 21:56
@adityamaru adityamaru requested a review from stevendanna July 19, 2023 21:58
@adityamaru adityamaru force-pushed the clusterwide-profile branch from e78fb2f to f5e26ec Compare July 20, 2023 12:28
This change includes the collection of cluster-wide, active tracing
spans to a job's execution details. The traces are stored in a zip
with a text and jaegar json file per node, that contain the active
tracing spans associated with the current execution of the job.

Once cockroachdb#106879
and cockroachdb#107210
merge a trace.zip will be generated everytime a user requests
new execution details from the job details page. This zip will
be downloadable from the job details page itself.

Informs: cockroachdb#102794
Release note: None
@adityamaru adityamaru force-pushed the clusterwide-profile branch from f5e26ec to 8fc74f2 Compare July 24, 2023 18:49
@adityamaru
Copy link
Contributor Author

TFTR!

bors r=stevendanna

@craig
Copy link
Contributor

craig bot commented Jul 25, 2023

Build succeeded:

@craig craig bot merged commit 451d761 into cockroachdb:master Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants