Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: sql: add tests and fixes for CTAS with every vtable #106288

Merged
merged 6 commits into from
Jul 6, 2023
Merged

release-22.2: sql: add tests and fixes for CTAS with every vtable #106288

merged 6 commits into from
Jul 6, 2023

Conversation

ecwall
Copy link
Contributor

@ecwall ecwall commented Jul 6, 2023 •
edited
Loading

Backport:

Please see individual PRs for details.

CREATE MATERIALIZED VIEW AS is skipped in 22.2 to avoid "views do not currently support * expressions" error.

/cc @cockroachdb/release

Release justification: Add tests and fixes for CREATE AS sourcing vtables.

ecwall added 2 commits July 6, 2023 10:25
@ecwall
test: add query to output of SQLRunner.ExpectErr
c549729 
Add incorrectly succeeding query to output of SQLRunner.ExpectErr to
make debugging easier when used in a loop. It now matches the behavior of
SQLRunner.Exec.

Release note: None
@ecwall
sql: exclude anonymous database from pg_catalog and pg_extension sche…
be48c12 
…mas in TableName.FQString()

Fixes #105929

`"".pg_extension.spatial_ref_sys` is the output of `TableName.FQString()` for
`spatial_ref_sys` which results in an error when trying to use the value:

```
[email protected]:26257/movr> SELECT count(*) FROM pg_extension.spatial_ref_sys;
  count
---------
   6139
(1 row)

Time: 17ms total (execution 17ms / network 0ms)

[email protected]:26257/movr> SELECT count(*) FROM "".pg_extension.spatial_ref_sys;
ERROR: cannot access virtual schema in anonymous database
SQLSTATE: 42704
HINT: verify that the current database is set
```

This PR fixes this by removing the `"".` prefix.

Release note: None
@ecwall ecwall requested review from a team as code owners July 6, 2023 14:27
@ecwall ecwall requested a review from cucaroach July 6, 2023 14:27
@blathers-crl
Copy link

blathers-crl bot commented Jul 6, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

ecwall added 4 commits July 6, 2023 12:28
@ecwall
sql: add tests for CTAS with every vtable
1d376fc 
Informs #105895

Adds tests for CREATE TABLE AS sourcing from all vtables.

CREATE MATERIALIZED VIEW AS is skipped in 22.2 to avoid
"views do not currently support * expressions" error.

Release note: None
@ecwall
sql: fix CREATE AS sourcing pg_catalog.pg_prepared_statements panic
3abe8a6 
Fixes #106166

Fixes a bug discovered in #105895 that caused a panic when running these
statements because planner.preparedStatements was nil:
CREATE TABLE t AS SELECT * FROM pg_catalog.pg_prepared_statements;
CREATE MATERIALIZED VIEW v AS SELECT * FROM pg_catalog.pg_prepared_statements;

Release note (bug fix): Fix panic executing CREATE AS with
pg_catalog.pg_prepared_statements source. For example:
CREATE TABLE t AS SELECT * FROM pg_catalog.pg_prepared_statements;
CREATE MATERIALIZED VIEW v AS SELECT * FROM pg_catalog.pg_prepared_statements;
@ecwall
sql: fix CREATE AS sourcing pg_catalog.pg_cursors panic
a556206 
Fixes #106167

Fixes a bug discovered in #105895 that caused a panic when running these
statements because planner.sqlCursors was nil:
CREATE TABLE t AS SELECT * FROM pg_catalog.pg_cursors;
CREATE MATERIALIZED VIEW v AS SELECT * FROM pg_catalog.pg_cursors;

Release note (bug fix): Fix panic executing CREATE AS with
pg_catalog.cursors source. For example:
CREATE TABLE t AS SELECT * FROM pg_catalog.pg_cursors;
CREATE MATERIALIZED VIEW v AS SELECT * FROM pg_catalog.pg_cursors;
@ecwall
sql: remove TestCreateAsVTable brokenTables
5b7784a 
Informs #105895

Remove the broken tables map now that it is empty.

Release note: None
@ecwall ecwall changed the title release-22.2: sql: add tests and fixes for CTAS, CMVAS with every vtable release-22.2: sql: add tests and fixes for CTAS with every vtable Jul 6, 2023
@ecwall ecwall merged commit 4cfe619 into cockroachdb:release-22.2 Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chengxiong-ruan chengxiong-ruan chengxiong-ruan approved these changes

@cucaroach cucaroach Awaiting requested review from cucaroach cucaroach is a code owner automatically assigned from cockroachdb/sql-queries

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ecwall @cockroach-teamcity @chengxiong-ruan