Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: CREATE AS sourcing pg_catalog.pg_cursors nil pointer dereference #106167

Closed
ecwall opened this issue Jul 5, 2023 · 0 comments · Fixed by #106203
Closed

sql: CREATE AS sourcing pg_catalog.pg_cursors nil pointer dereference #106167

ecwall opened this issue Jul 5, 2023 · 0 comments · Fixed by #106203
Assignees
@ecwall
Labels
A-sql-vtables Virtual tables - pg_catalog, information_schema etc C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. db-cy-23 T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@ecwall
Copy link
Contributor

ecwall commented Jul 5, 2023 •
edited by exalate-issue-sync bot
Loading

Running
CREATE TABLE t AS SELECT * FROM pg_catalog.pg_cursors;
or
CREATE MATERIALIZED VIEW v AS SELECT * FROM pg_catalog.pg_cursors;

results in a nil pointer dereference here

cockroach/pkg/sql/pg_catalog.go

Line 3879 in 9e84bfe

for name, c := range p.sqlCursors.list() {

Jira issue: CRDB-29436

Epic CRDB-27601
@ecwall ecwall added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-sql-vtables Virtual tables - pg_catalog, information_schema etc T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Jul 5, 2023
@ecwall ecwall self-assigned this Jul 5, 2023
@ecwall ecwall mentioned this issue Jul 5, 2023
Merged
craig bot pushed a commit that referenced this issue Jul 5, 2023
@knz @ecwall
Merge #106122 #106203
e8aedca 
106122: server: use HTTP query parameter `cluster` for manual selection r=yuzefovich a=knz

Informs #106068.
Epic: CRDB-29380

Prior to this patch, there was a debug-only way to manually force a HTTP request to be routed to a particular virtual cluster through the server controller. This was achieved via the query parameter `tenant_name`.

This patch renames the paramater to `cluster`, for a better UX coherence with the option of the same name in `cockroach sql`.

Release note: None

106203: sql: fix CREATE AS sourcing vtable panics r=chengxiong-ruan a=ecwall

Fixes #106166
Fixes #106167
Fixes #106168
Informs #105895

Fixes panics affects CREATE AS sourcing from vtables. These statements now work properly:
```
CREATE TABLE t AS SELECT * FROM pg_catalog.pg_prepared_statements;
CREATE MATERIALIZED VIEW v AS SELECT * FROM pg_catalog.pg_prepared_statements;
CREATE TABLE t AS SELECT * FROM pg_catalog.pg_cursors;
CREATE MATERIALIZED VIEW v AS SELECT * FROM pg_catalog.pg_cursors;
CREATE TABLE t AS SELECT * FROM crdb_internal.create_statements;
CREATE MATERIALIZED VIEW v AS SELECT * FROM crdb_internal.create_statements;
```

Co-authored-by: Raphael 'kena' Poss <[email protected]>
Co-authored-by: Evan Wall <[email protected]>
@craig craig bot closed this as completed in eaa7742 Jul 5, 2023
@ecwall ecwall mentioned this issue Jul 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ecwall ecwall

Labels
A-sql-vtables Virtual tables - pg_catalog, information_schema etc C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. db-cy-23 T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: fix CREATE AS sourcing vtable panics
1 participant
@ecwall