Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add tests for CTAS, CMVAS with every vtable #106157

Merged
merged 3 commits into from
Jul 5, 2023
Merged

sql: add tests for CTAS, CMVAS with every vtable #106157

merged 3 commits into from
Jul 5, 2023

Conversation

ecwall
Copy link
Contributor

@ecwall ecwall commented Jul 5, 2023

Informs #105895

Adds tests for CREATE TABLE AS, CREATE MATERIALIZED VIEW AS sourcing from
all vtables.

Release note: None

@ecwall ecwall requested review from a team as code owners July 5, 2023 13:14
@ecwall ecwall requested a review from mgartner July 5, 2023 13:14
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@ecwall ecwall added backport-22.2.x backport-23.1.x Flags PRs that need to be backported to 23.1 labels Jul 5, 2023
chengxiong-ruan
chengxiong-ruan approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@chengxiong-ruan chengxiong-ruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for working on this.

pkg/sql/create_as_test.go

// These are the vtables that need to be fixed.
// The map should be empty if all vtables are supported.
brokenTables := map[string]struct{}{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Could add a TODO(with issue) and more words on why these tables are broken?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added issues.

ecwall added 3 commits July 5, 2023 10:24
@ecwall
test: add query to output of SQLRunner.ExpectErr
eadaa0e 
Add incorrectly succeeding query to output of SQLRunner.ExpectErr to
make debugging easier when used in a loop. It now matches the behavior of
SQLRunner.Exec.

Release note: None
@ecwall
sql: exclude anonymous database from pg_catalog and pg_extension sche…
b3c2312 
…mas in TableName.FQString()

Fixes #105929

`"".pg_extension.spatial_ref_sys` is the output of `TableName.FQString()` for
`spatial_ref_sys` which results in an error when trying to use the value:

```
[email protected]:26257/movr> SELECT count(*) FROM pg_extension.spatial_ref_sys;
  count
---------
   6139
(1 row)

Time: 17ms total (execution 17ms / network 0ms)

[email protected]:26257/movr> SELECT count(*) FROM "".pg_extension.spatial_ref_sys;
ERROR: cannot access virtual schema in anonymous database
SQLSTATE: 42704
HINT: verify that the current database is set
```

This PR fixes this by removing the `"".` prefix.

Release note: None
@ecwall
sql: add tests for CTAS, CMVAS with every vtable
68a9c38 
Informs #105895

Adds tests for CREATE TABLE AS, CREATE MATERIALIZED VIEW AS sourcing from
all vtables.

Release note: None
@ecwall
Copy link
Contributor Author

ecwall commented Jul 5, 2023

bors r=chengxiong-ruan

@craig
Copy link
Contributor

craig bot commented Jul 5, 2023

Build succeeded:

@craig craig bot merged commit e337ad7 into cockroachdb:master Jul 5, 2023
@blathers-crl blathers-crl bot mentioned this pull request Jul 5, 2023
Merged
@blathers-crl
Copy link

blathers-crl bot commented Jul 5, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

error creating merge commit from eadaa0e to blathers/backport-release-22.2-106157: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.

error setting reviewers, but backport branch blathers/backport-release-23.1-106157 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/106191/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 23.1.x failed. See errors above.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@tbg tbg mentioned this pull request Jul 6, 2023
Closed
@ecwall ecwall mentioned this pull request Jul 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chengxiong-ruan chengxiong-ruan chengxiong-ruan approved these changes

@mgartner mgartner Awaiting requested review from mgartner mgartner was automatically assigned from cockroachdb/sql-queries

Assignees
No one assigned
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ecwall @cockroach-teamcity @chengxiong-ruan