Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: sql: add tests for CTAS, CMVAS with every vtable #106191

Merged
merged 3 commits into from
Jul 6, 2023
Merged

release-23.1: sql: add tests for CTAS, CMVAS with every vtable #106191

merged 3 commits into from
Jul 6, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jul 5, 2023 •
edited by ecwall
Loading

Backport 3/3 commits from #106157 on behalf of @ecwall.

/cc @cockroachdb/release

Informs #105895

Adds tests for CREATE TABLE AS, CREATE MATERIALIZED VIEW AS sourcing from
all vtables.

Release note: None

Release justification: Add missing test coverage

ecwall added 3 commits June 30, 2023 19:40
@ecwall
test: add query to output of SQLRunner.ExpectErr
55b7520 
Add incorrectly succeeding query to output of SQLRunner.ExpectErr to
make debugging easier when used in a loop. It now matches the behavior of
SQLRunner.Exec.

Release note: None
@ecwall
sql: exclude anonymous database from pg_catalog and pg_extension sche…
6b4478c 
…mas in TableName.FQString()

Fixes #105929

`"".pg_extension.spatial_ref_sys` is the output of `TableName.FQString()` for
`spatial_ref_sys` which results in an error when trying to use the value:

```
[email protected]:26257/movr> SELECT count(*) FROM pg_extension.spatial_ref_sys;
  count
---------
   6139
(1 row)

Time: 17ms total (execution 17ms / network 0ms)

[email protected]:26257/movr> SELECT count(*) FROM "".pg_extension.spatial_ref_sys;
ERROR: cannot access virtual schema in anonymous database
SQLSTATE: 42704
HINT: verify that the current database is set
```

This PR fixes this by removing the `"".` prefix.

Release note: None
@ecwall
sql: add tests for CTAS, CMVAS with every vtable
24b2229 
Informs #105895

Adds tests for CREATE TABLE AS, CREATE MATERIALIZED VIEW AS sourcing from
all vtables.

Release note: None
@blathers-crl blathers-crl bot requested review from a team as code owners July 5, 2023 17:22
@blathers-crl blathers-crl bot requested a review from rytaft July 5, 2023 17:22
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-106157 branch from 6b4478c to 664597b Compare July 5, 2023 17:22
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jul 5, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-106157 branch from a26d4a8 to 24b2229 Compare July 5, 2023 17:22
@blathers-crl
Copy link
Author

blathers-crl bot commented Jul 5, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@ecwall ecwall merged commit a8ff654 into release-23.1 Jul 6, 2023
@ecwall ecwall deleted the blathers/backport-release-23.1-106157 branch July 6, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chengxiong-ruan chengxiong-ruan chengxiong-ruan approved these changes

@rytaft rytaft Awaiting requested review from rytaft rytaft was automatically assigned from cockroachdb/sql-queries

Assignees

@ecwall ecwall

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @chengxiong-ruan @ecwall