ui: fix columns selector being cut #104670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when the number of rows on the Jobs table was smaller than 3, the height of the area was not enough to show the columns selector, making it get cut and not displayed the "Apply" button unless you scrolled. This commit adds a min-height for that area, making sure the column selector will be displayed completely. Fixes cockroachdb#104619 Release note (bug fix): The column selector on the Jobs page is no longer getting cut.
maryliag
added
backport-22.2.x
backport-23.1.x
|
This change is |
gtr
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
Nice!
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @maryliag)
|
TFTR! |
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
bors r+ |
|
Build failed: |
|
bors r+ |
|
Build failed: |
|
bors r+ |
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
bors r+ single on |
|
Build succeeded: |
This was referenced Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the number of rows on the Jobs table was smaller than 3, the height of the area was not enough to show the columns selector, making it get cut and not displayed the "Apply" button unless you scrolled.
This commit adds a min-height for that area, making sure the column selector will be displayed completely.
Fixes #104619
Before
After
Release note (bug fix): The column selector on the Jobs page is no longer getting cut.