Skip to content

Commit

Permalink
Merge #104670
Browse files Browse the repository at this point in the history
104670: ui: fix columns selector being cut r=maryliag a=maryliag

Previously, when the number of rows on the Jobs table was smaller than 3, the height of the area was not enough to show the columns selector, making it get cut and not displayed the "Apply" button unless you scrolled.
This commit adds a min-height for that area, making sure the column selector will be displayed completely.

Fixes #104619

Before
<img width="514" alt="Screenshot 2023-06-09 at 12 09 57 PM" src="https://github.com/cockroachdb/cockroach/assets/1017486/5aaf1ee8-6040-4439-851b-3aecb8483511">


After
<img width="731" alt="Screenshot 2023-06-09 at 12 17 14 PM" src="https://github.com/cockroachdb/cockroach/assets/1017486/f62a1590-252b-41d0-9349-23b722def09e">


Release note (bug fix): The column selector on the Jobs page is no longer getting cut.

Co-authored-by: maryliag <[email protected]>
  • Loading branch information
craig[bot] and maryliag committed Jun 12, 2023
2 parents da83a14 + 465e30b commit 5d630ae
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions pkg/ui/workspaces/cluster-ui/src/jobs/jobs.module.scss
Original file line number Diff line number Diff line change
Expand Up @@ -255,4 +255,5 @@
.table-area {
position: relative;
overflow-x: scroll;
min-height: 450px;
}

0 comments on commit 5d630ae

Please sign in to comment.