Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db console: high watermark missing from jobs table #104619

Closed
amruss opened this issue Jun 8, 2023 · 2 comments · Fixed by #104670
Closed

db console: high watermark missing from jobs table #104619

amruss opened this issue Jun 8, 2023 · 2 comments · Fixed by #104670
Assignees
@maryliag
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@amruss
Copy link
Contributor

amruss commented Jun 8, 2023 •
edited by cockroach-jira-scripts
Loading

The high watermark information is missing in the db console. Even when clicking the column in the column dropdown, it does not appear. This information is critical to changefeed users.

high_watermark_missing.mov

To reproduce, log into the telemetry cluster's db console and go to the jobs table.

Alternatively, we could nix the high watermark column and include that information in the status column instead.

Jira issue: CRDB-28638
@amruss amruss added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Jun 8, 2023
@maryliag
Copy link
Contributor

maryliag commented Jun 8, 2023

the column shows once the Apply is clicked: https://www.loom.com/share/344aba8d2aa6465d8299d4a8a1f09d37
this issue is about making sure the column selector is not cut so the Apply always show. On the SQL Activity page we had to add a min height for the table area to solve this issue. A similar behaviour needs to be added to this page.

@amruss
Copy link
Contributor Author

amruss commented Jun 8, 2023

Thank you!

@maryliag maryliag mentioned this issue Jun 9, 2023
Merged
@maryliag maryliag self-assigned this Jun 9, 2023
craig bot pushed a commit that referenced this issue Jun 12, 2023
@maryliag
Merge #104670
5d630ae 
104670: ui: fix columns selector being cut r=maryliag a=maryliag

Previously, when the number of rows on the Jobs table was smaller than 3, the height of the area was not enough to show the columns selector, making it get cut and not displayed the "Apply" button unless you scrolled.
This commit adds a min-height for that area, making sure the column selector will be displayed completely.

Fixes #104619

Before
<img width="514" alt="Screenshot 2023-06-09 at 12 09 57 PM" src="https://github.com/cockroachdb/cockroach/assets/1017486/5aaf1ee8-6040-4439-851b-3aecb8483511">


After
<img width="731" alt="Screenshot 2023-06-09 at 12 17 14 PM" src="https://github.com/cockroachdb/cockroach/assets/1017486/f62a1590-252b-41d0-9349-23b722def09e">


Release note (bug fix): The column selector on the Jobs page is no longer getting cut.

Co-authored-by: maryliag <[email protected]>
@craig craig bot closed this as completed in 465e30b Jun 12, 2023
@blathers-crl blathers-crl bot mentioned this issue Jun 12, 2023
Merged
blathers-crl bot pushed a commit that referenced this issue Jun 12, 2023
@maryliag
ui: fix columns selector being cut
7c8eea3 
Previously, when the number of rows on the Jobs table was smaller
than 3, the height of the area was not enough to show the
columns selector, making it get cut and not displayed the "Apply"
button unless you scrolled.
This commit adds a min-height for that area, making sure the
column selector will be displayed completely.

Fixes #104619

Release note (bug fix): The column selector on the Jobs page
is no longer getting cut.
@blathers-crl blathers-crl bot mentioned this issue Jun 12, 2023
Merged
blathers-crl bot pushed a commit that referenced this issue Jun 12, 2023
@maryliag
ui: fix columns selector being cut
9571045 
Previously, when the number of rows on the Jobs table was smaller
than 3, the height of the area was not enough to show the
columns selector, making it get cut and not displayed the "Apply"
button unless you scrolled.
This commit adds a min-height for that area, making sure the
column selector will be displayed completely.

Fixes #104619

Release note (bug fix): The column selector on the Jobs page
is no longer getting cut.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryliag maryliag

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: fix columns selector being cut maryliag/cockroach
2 participants
@maryliag @amruss