Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jobs: add system.job_info to the debug zip #98829

Closed
adityamaru opened this issue Mar 17, 2023 · 1 comment
Closed

jobs: add system.job_info to the debug zip #98829

adityamaru opened this issue Mar 17, 2023 · 1 comment
Assignees
Labels
branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-disaster-recovery

Comments

@adityamaru
Copy link
Contributor

adityamaru commented Mar 17, 2023

system.job_info will soon contain the payload and progress of all jobs running in a cluster. Dump its contents after appropriate redaction to the debug zip.

Jira issue: CRDB-25538

Epic CRDB-8964

@adityamaru adityamaru added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) GA-blocker branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 labels Mar 17, 2023
@blathers-crl
Copy link

blathers-crl bot commented Mar 17, 2023

cc @cockroachdb/disaster-recovery

@dt dt closed this as completed Apr 5, 2023
adityamaru added a commit to adityamaru/cockroach that referenced this issue Apr 11, 2023
We do not dump the value column when
collecting a redacted zip as it might contain
sensitive data.

Release note: None
Informs: cockroachdb#98829
craig bot pushed a commit that referenced this issue Apr 11, 2023
99856: roachtest: update 22.2 predecessor to 22.1.18 r=renatolabs a=cameronnunez

Part of: https://cockroachlabs.atlassian.net/browse/REL-309

Release note: None

100200: pgwire: add server.cockroach_cloud.max_client_connections_per_gateway cluster setting r=alyshanjahani-crl a=alyshanjahani-crl

This setting specifies a maximum number of external connections that a server can have open at any given time. External is defined as connections that are not root connections. In the future, we can have the definition of external be a configurable list of users.
<0 - Connections are unlimited (existing behavior)
=0 - External connections are disabled
>0 - External connections are limited
If a new connection would exceed this limit, an error message is returned as postgres: "cluster connections are limited" with the 53300 error code that corresponds to "too many connections".

This functionality is required for serverless.
Part of: https://cockroachlabs.atlassian.net/browse/CC-9288

Release note: None

100742: ownership of Jobs to DR team r=shermanCRL a=shermanCRL

Epic: CRDB-26380

100911: cli: add system.job_info to debug zip r=adityamaru a=adityamaru

We do not dump the value column when
collecting a redacted zip as it might contain
sensitive data.

Release note: None
Informs: #98829

101095: add DR, CDC, Jobs labels to test failures r=shermanCRL a=shermanCRL

Ensure that test failures via the `cockroach-teamcity` bot labels DR, CDC and Jobs teams

Epic: none
Jira: none


101105: sql/schemachanger: relax rules for setting constraint names r=fqazi a=fqazi

Previously, the rules for adding and removing constraint names were strict, which could lead to mixed version compatibility issues. Specifically, plans on the 23.1 branch could have names set in later stages violating a rule that said a constraint should be public/non-public with the name. To address this, this patch will relax these rules to have Precedence instead of SameStagePrecedence

Fixes: #100908

Release note: None

101169: roachtest: prevent shared mutable state across restore roachtest runs r=benbardin a=msbutler

Previously, all `restore/*` roachtests run with `--count` would provide incomprehensible results because multiple roachtest runs of the same test would override each other's state. Specifically, the latest call of `test_spec.Run()`, would override the `test.Test` harness, and `syncedCluster.Cluster` used by all other tests with the same registration.

This patch fixes this problem by moving all fields in `restoreSpecs` that are set during test execution (i.e. a `test_spec.Run` call), to a new `restoreDriver` struct. Now, `restoreSpecs` gets defined during test registration and is shared across test runs, while `restoreDriver` gets set within a test run.

Epic: none

Release note: None

Co-authored-by: Cameron Nunez <[email protected]>
Co-authored-by: Alyshan Jahani <[email protected]>
Co-authored-by: Matt Sherman <[email protected]>
Co-authored-by: adityamaru <[email protected]>
Co-authored-by: Faizan Qazi <[email protected]>
Co-authored-by: Michael Butler <[email protected]>
blathers-crl bot pushed a commit that referenced this issue Apr 11, 2023
We do not dump the value column when
collecting a redacted zip as it might contain
sensitive data.

Release note: None
Informs: #98829
blathers-crl bot pushed a commit that referenced this issue Apr 11, 2023
We do not dump the value column when
collecting a redacted zip as it might contain
sensitive data.

Release note: None
Informs: #98829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-disaster-recovery
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants