Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ownership of Jobs to DR team #100742

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Conversation

shermanCRL
Copy link
Contributor

@shermanCRL shermanCRL commented Apr 5, 2023

Epic: CRDB-26380

@shermanCRL shermanCRL requested a review from dt April 5, 2023 18:24
@shermanCRL shermanCRL requested a review from a team as a code owner April 5, 2023 18:24
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@dt
Copy link
Member

dt commented Apr 11, 2023

Approved but I'm not actually sure we want/need this?

Whoever wants to review jobs PRs -- be that DR or CDC or whoever else is pitching in at the moment -- can just be added to the GitHub team for jobs PRs can't they?

@shermanCRL
Copy link
Contributor Author

bors r+

@shermanCRL
Copy link
Contributor Author

Whoever wants to review jobs PRs -- be that DR or CDC or whoever else is pitching in at the moment -- can just be added to the GitHub team for jobs PRs can't they?

Yeah good question. I’m not sure that list is well-maintained or is worth maintaining? May be simpler to just assign to an actual team.

@shermanCRL
Copy link
Contributor Author

bors r+

@craig craig bot merged commit 5fd45da into cockroachdb:master Apr 11, 2023
@craig
Copy link
Contributor

craig bot commented Apr 11, 2023

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants