-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: add system.job_info to debug zip #100911
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
adityamaru
force-pushed
the
add-info-to-zip
branch
2 times, most recently
from
April 10, 2023 16:34
1df5633
to
e0c5406
Compare
knz
approved these changes
Apr 10, 2023
We do not dump the value column when collecting a redacted zip as it might contain sensitive data. Release note: None Informs: cockroachdb#98829
adityamaru
force-pushed
the
add-info-to-zip
branch
from
April 11, 2023 04:20
e0c5406
to
26cc3d5
Compare
TFTR! bors r=knz |
bors retry |
bors r- |
bors r+ |
Build succeeded: |
blathers backport 23.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not dump the value column when
collecting a redacted zip as it might contain
sensitive data.
Release note: None
Informs: #98829