Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: add system.job_info to debug zip #100911

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

adityamaru
Copy link
Contributor

We do not dump the value column when
collecting a redacted zip as it might contain
sensitive data.

Release note: None
Informs: #98829

@adityamaru adityamaru requested a review from dt April 7, 2023 14:00
@adityamaru adityamaru requested a review from a team as a code owner April 7, 2023 14:00
@blathers-crl
Copy link

blathers-crl bot commented Apr 7, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@adityamaru adityamaru added the backport-23.1.x Flags PRs that need to be backported to 23.1 label Apr 7, 2023
@adityamaru adityamaru force-pushed the add-info-to-zip branch 2 times, most recently from 1df5633 to e0c5406 Compare April 10, 2023 16:34
@adityamaru adityamaru requested a review from a team April 10, 2023 16:34
We do not dump the value column when
collecting a redacted zip as it might contain
sensitive data.

Release note: None
Informs: cockroachdb#98829
@adityamaru
Copy link
Contributor Author

TFTR!

bors r=knz

@dhartunian dhartunian removed the request for review from a team April 11, 2023 14:36
@adityamaru
Copy link
Contributor Author

bors retry

@adityamaru
Copy link
Contributor Author

bors r-

@adityamaru
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 11, 2023

Build succeeded:

@craig craig bot merged commit 5fd45da into cockroachdb:master Apr 11, 2023
@adityamaru adityamaru deleted the add-info-to-zip branch April 11, 2023 18:35
@adityamaru
Copy link
Contributor Author

blathers backport 23.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants