Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

admin api: Add PGCode to generic message #98596

Closed
j82w opened this issue Mar 14, 2023 · 0 comments · Fixed by #98601
Closed

admin api: Add PGCode to generic message #98596

j82w opened this issue Mar 14, 2023 · 0 comments · Fixed by #98601
Assignees
@j82w
Labels
A-sql-observability Related to observability of the SQL layer C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@j82w
Copy link
Contributor

j82w commented Mar 14, 2023 •
edited by cockroach-jira-scripts
Loading

The current error message returned on the SQL Activity pages is:
bundle.js:1793 Error Loading statements: RequestError: An internal server error has occurred. Please check your CockroachDB logs for more details

It would be ideal to return the PGCode to easily troubleshoot why the underlying query failed. It would avoid the pain of needing to get the db logs and attempt to correlate them with the ui console logs.

Jira issue: CRDB-25351
@j82w j82w added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-sql-observability Related to observability of the SQL layer T-sql-observability labels Mar 14, 2023
@j82w j82w self-assigned this Mar 14, 2023
@j82w j82w mentioned this issue Mar 14, 2023
Merged
craig bot pushed a commit that referenced this issue Mar 16, 2023
@kvoli
Merge #98601 #98715
81a9f1d 
98601: ui: add PGCode to admin api errors r=j82w a=j82w

Adding the PGCode makes it easy to identify
the underlying issue of why the request failed.

old error:
```
RequestError: An internal server error has occurred.
Please check your CockroachDB logs for more details.
```

new error
```
RequestError: An internal server error has occurred. 
Please check your CockroachDB logs for more details. Error Code: 53200
```

<img width="2058" alt="Screenshot 2023-03-14 at 2 51 57 PM" src="https://user-images.githubusercontent.com/8868107/225108075-5db442da-699f-487b-852c-732eb030f644.png">


Epic: none
Closes: #98596

Release note: none

98715: kvserver: deflake and unskip split race uninit rhs r=nvanbenschoten a=kvoli

`TestStoreRangeSplitRaceUninitializedRHS` was skipped some time ago, in mid 2021 (#67082). The test was skipped due to flakes that appeared related to untimely test cluster startup.

This commit unskips the test and makes minor adjustments in order to be current with semantics of Raft transport. Without these adjustments, the `MsgVote` sent every microsecond with the intention of triggering a race, would completely fill up  the Raft transport send queue. Once the queue was full, the test would fail as requests are dropped.

This commit updates the `MsgVote` send loop logic to not require every `MsgVote` request to be sent for the test to succeed.

Resolves: #66480

Release note: None

Co-authored-by: j82w <[email protected]>
Co-authored-by: Austen McClernon <[email protected]>
@craig craig bot closed this as completed in b6e0f76 Mar 16, 2023
This was referenced Apr 6, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j82w j82w

Labels
A-sql-observability Related to observability of the SQL layer C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: add PGCode to admin api errors
1 participant
@j82w