kvserver: deflake and unskip split race uninit rhs #98715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`TestStoreRangeSplitRaceUninitializedRHS` was skipped some time ago, in mid 2021 (cockroachdb#67082). The test was skipped due to flakes that appeared related to untimely test cluster startup. This commit unskips the test and makes minor adjustments in order to be current with semantics of Raft transport. Without these adjustments, the `MsgVote` sent every microsecond with the intention of triggering a race, would completely fill up the Raft transport send queue. Once the queue was full, the test would fail as requests are dropped. This commit updates the `MsgVote` send loop logic to not require every `MsgVote` request to be sent for the test to succeed. Resolves: cockroachdb#66480 Release note: None
|
This change is |
nvanbenschoten
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @kvoli)
|
bors r=nvanbenschoten |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestStoreRangeSplitRaceUninitializedRHSwas skipped some time ago, in mid 2021 (#67082). The test was skipped due to flakes that appeared related to untimely test cluster startup.This commit unskips the test and makes minor adjustments in order to be current with semantics of Raft transport. Without these adjustments, the
MsgVotesent every microsecond with the intention of triggering a race, would completely fill up the Raft transport send queue. Once the queue was full, the test would fail as requests are dropped.This commit updates the
MsgVotesend loop logic to not require everyMsgVoterequest to be sent for the test to succeed.Resolves: #66480
Release note: None