Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: ui: add PGCode to admin api errors #100838

Merged
merged 1 commit into from
Apr 6, 2023
Merged

release-22.1: ui: add PGCode to admin api errors #100838

merged 1 commit into from
Apr 6, 2023

Conversation

j82w
Copy link
Contributor

@j82w j82w commented Apr 6, 2023

Backport 1/1 commits from #98601.

/cc @cockroachdb/release


Adding the PGCode makes it easy to identify
the underlying issue of why the request failed.

old error:

RequestError: An internal server error has occurred.
Please check your CockroachDB logs for more details.

new error

RequestError: An internal server error has occurred. 
Please check your CockroachDB logs for more details. Error Code: 53200

Screenshot 2023-03-14 at 2 51 57 PM

Epic: none
Closes: #98596

Release note: none

Release justification: improve troubleshooting

Adding the Error Code makes it easy to identify
the underlying issue of why the request failed.

old error:
```RequestError: An internal server error has occurred.
Please check your CockroachDB logs for more details.```

new error
```RequestError: An internal server error has occurred.
Please check your CockroachDB logs for more details. Error Code: 53200```

Epic: none
Closes: #98596

Release note: none
@j82w j82w requested a review from a team April 6, 2023 17:35
@j82w j82w requested a review from a team as a code owner April 6, 2023 17:35
@blathers-crl
Copy link

blathers-crl bot commented Apr 6, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @j82w)

@j82w j82w merged commit 8c6f207 into cockroachdb:release-22.1 Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants