storage: remove V22_2 gates and related logic/migrations/etc #96764
Assignees
Comments
celiala
added
C-cleanup
blathers-crl
bot
added
the
A-storage
|
Three more for storage:
|
RaduBerinde
added a commit
to RaduBerinde/cockroach
that referenced
this issue
Feb 8, 2023
This change removes any code that handles pre-22.2 versions. Features that are in 22.2 (like range keys) are now always enabled. Any new store always uses at least the 22.2 pebble format version. Release note: None Epic: none Fixes: cockroachdb#96764
RaduBerinde
added a commit
to RaduBerinde/cockroach
that referenced
this issue
Feb 8, 2023
This change removes any code that handles pre-22.2 versions. Features that are in 22.2 (like range keys) are now always enabled. Any new store always uses at least the 22.2 pebble format version. Release note: None Epic: none Fixes: cockroachdb#96764
RaduBerinde
added a commit
to RaduBerinde/cockroach
that referenced
this issue
Feb 8, 2023
This change removes any code that handles pre-22.2 versions. Features that are in 22.2 (like range keys) are now always enabled. Any new store always uses at least the 22.2 pebble format version. Release note: None Epic: none Fixes: cockroachdb#96764
RaduBerinde
added a commit
to RaduBerinde/cockroach
that referenced
this issue
Feb 9, 2023
This change removes any code that handles pre-22.2 versions. Features that are in 22.2 (like range keys) are now always enabled. Any new store always uses at least the 22.2 pebble format version. Release note: None Epic: none Fixes: cockroachdb#96764
craig bot
pushed a commit
that referenced
this issue
Feb 13, 2023
96805: storage: remove pre-22.2 code r=RaduBerinde a=RaduBerinde This change removes any code that handles pre-22.2 versions. Features that are in 22.2 (like range keys) are now always enabled. Any new store always uses at least the 22.2 pebble format version. Release note: None Epic: none Fixes: #96764 96872: ui: add statement fingerprint to insights r=j82w a=j82w 1. Removes contention events from insights. This avoids tracking and storing duplicate information. 2. Add database_name, schema_name, table_name, index_name, contending_pretty_key to crdb_internal.transaction_contention_events. This avoids needing to join with multiple tables and makes it easier for users to understand. 3. Add waiting statement info to the insights transaction details page. This way if users have a large transaction with multiple statements with multiple contention events they can see which specific statement was waited on. 4. Add blocking transaction fingerprint to the insight statement details page. The user can now see which transaction is blocking the statement ,and it has a link to the blocking transaction activity page. https://www.loom.com/share/de37b2e3007d48c2a1e3ad39ed334e20 closes: #91665 Release note (ui change): Add waiting statement id and fingerprint to insights transaction details page. Add blocking transaction id and fingerprint to the insights statement page. 96954: workload/schemachange: skip tsquery/tsvector types in mixed version envs r=fqazi a=fqazi Previously, the randomized schema change workload in a mixed version environment attempted to create tables with the tsvector/tsquery types. This could lead to syntax errors on older nodes that do not know of this. This patch, avoids using these types until the version of the cluster hits 23.1. Epic: none Release note: None Co-authored-by: Radu Berinde <[email protected]> Co-authored-by: j82w <[email protected]> Co-authored-by: Faizan Qazi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Now that we've bumped minBinary to 22.2[1], we should now remove all V22_2* version gates and related gated logic/migrations/etc as applicable.
V22_2 gates for Storage[2]:
[1] #95530
[2] Using git blame from https://github.com/cockroachdb/cockroach/blame/984c24b05bfe3c04ffd7bec5784d475796504522/pkg/clusterversion/cockroach_versions.go
Jira issue: CRDB-24319
The text was updated successfully, but these errors were encountered: