Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replication: remove V22_2 gates and related logic/migrations/etc #96760

Closed
celiala opened this issue Feb 7, 2023 · 2 comments · Fixed by #96786
Closed

replication: remove V22_2 gates and related logic/migrations/etc #96760

celiala opened this issue Feb 7, 2023 · 2 comments · Fixed by #96786
Assignees
@erikgrinaker
Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.

Comments

@celiala
Copy link
Collaborator

celiala commented Feb 7, 2023 •
edited by erikgrinaker
Loading

Now that we've bumped minBinary to 22.2[1], we should now remove all V22_2* version gates and related gated logic/migrations/etc as applicable.

V22_2 gates for Replication[2]:

  • V22_2AddSSTableTombstones
  • V22_2GCHintInReplicaState

[1] #95530
[2] Using git blame from https://github.com/cockroachdb/cockroach/blame/984c24b05bfe3c04ffd7bec5784d475796504522/pkg/clusterversion/cockroach_versions.go

Jira issue: CRDB-24315
@celiala celiala added C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. T-kv-replication labels Feb 7, 2023
@blathers-crl
Copy link

blathers-crl bot commented Feb 7, 2023

cc @cockroachdb/replication

@celiala celiala mentioned this issue Feb 8, 2023
Closed
@erikgrinaker
Copy link
Contributor

I moved these over to storage (#96764):

  • V22_2MVCCRangeTombstones
  • V22_2EnsurePebbleFormatVersionRangeKeys
  • V22_2EnablePebbleFormatVersionRangeKeys

@erikgrinaker erikgrinaker self-assigned this Feb 8, 2023
@erikgrinaker erikgrinaker mentioned this issue Feb 8, 2023
Merged
@craig craig bot closed this as completed in 18c5a38 Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikgrinaker erikgrinaker

Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

clusterversion: remove replication version gates erikgrinaker/cockroach
2 participants
@erikgrinaker @celiala