insights: add blocking transaction fingerprint to statement details page #91665
Assignees
Labels
A-sql-observability
Related to observability of the SQL layer
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Comments
j82w
added
C-enhancement
craig bot
pushed a commit
that referenced
this issue
Nov 15, 2022
91668: ui: add contention info to insight statement details r=j82w a=j82w This changes the crdb_internal.cluster_execution_insights to store the names of contention key instead of the ids. This avoids complex join logic so the ui can display a eas format. This does not currently contain the blocking transaction fingerprint or the blocking statement information. The blocking fingerprint will be added in issue #91665 closes: #91187 https://www.loom.com/share/03e08c5a473844b3a637b9eb618b7866 Release note (ui change): Add the contention time, schema, database, table, and index info to insights statement details page. 91942: sql: use empty roachpb.TenantID for error return r=michae2 a=stevendanna MakeTenantID(0) panics. In other error cases in the code base, we return an empty struct. Epic: None Release note: None Co-authored-by: j82w <[email protected]> Co-authored-by: Steven Danna <[email protected]>
This was referenced Jan 5, 2023
craig bot
pushed a commit
that referenced
this issue
Feb 1, 2023
94973: multitenant: add SQL server startup guardrails r=[ajstorm,ajwerner] a=healthy-pod This code change prevents a SQL server from starting if its binary version is less than the tenant's active version. It makes `RowDecoder.DecodeRow` thread safe by making it accept a `*tree.DatumAlloc` and use a new alloc if its nil. The check runs after we run permanent upgrades because that's when the version setting is written to the settings table of the system tenant (and we want to apply this check to both system and secondary tenants). To guard against future changes to where we set the version, if GetClusterVersionFromStorage doesn't find a value for the version setting it will return an error because this means the version is not set yet. Release note: None Epic: [CRDB-10829](https://cockroachlabs.atlassian.net/browse/CRDB-10829) 95061: sql: add waiting stmt info to transaction_contention_events r=j82w a=j82w This adds the 'waiting_stmt_id' and 'waiting_stmt_fingerprint_id' to the transaction_contention_events. This makes it easier for users to figure out what the issue is when dealing with large transactions. part of: #91665 Release note: sql: adds the 'waiting_stmt_id' and 'waiting_stmt_fingerprint_id' to the transaction_contention_events 96284: roachtest: update asyncpg blocklist r=ZhouXing19 a=rafiss More support for subquery decorrelation made more tests pass. fixes #95498 Release note: None Co-authored-by: healthy-pod <[email protected]> Co-authored-by: j82w <[email protected]> Co-authored-by: Rafi Shamim <[email protected]>
craig bot
pushed a commit
that referenced
this issue
Feb 13, 2023
96805: storage: remove pre-22.2 code r=RaduBerinde a=RaduBerinde This change removes any code that handles pre-22.2 versions. Features that are in 22.2 (like range keys) are now always enabled. Any new store always uses at least the 22.2 pebble format version. Release note: None Epic: none Fixes: #96764 96872: ui: add statement fingerprint to insights r=j82w a=j82w 1. Removes contention events from insights. This avoids tracking and storing duplicate information. 2. Add database_name, schema_name, table_name, index_name, contending_pretty_key to crdb_internal.transaction_contention_events. This avoids needing to join with multiple tables and makes it easier for users to understand. 3. Add waiting statement info to the insights transaction details page. This way if users have a large transaction with multiple statements with multiple contention events they can see which specific statement was waited on. 4. Add blocking transaction fingerprint to the insight statement details page. The user can now see which transaction is blocking the statement ,and it has a link to the blocking transaction activity page. https://www.loom.com/share/de37b2e3007d48c2a1e3ad39ed334e20 closes: #91665 Release note (ui change): Add waiting statement id and fingerprint to insights transaction details page. Add blocking transaction id and fingerprint to the insights statement page. 96954: workload/schemachange: skip tsquery/tsvector types in mixed version envs r=fqazi a=fqazi Previously, the randomized schema change workload in a mixed version environment attempted to create tables with the tsvector/tsquery types. This could lead to syntax errors on older nodes that do not know of this. This patch, avoids using these types until the version of the cluster hits 23.1. Epic: none Release note: None Co-authored-by: Radu Berinde <[email protected]> Co-authored-by: j82w <[email protected]> Co-authored-by: Faizan Qazi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The insights statement details page only has the blocking id. It does not have the blocking fingerprint id. This is needs to it can be linked back to the actual query and the stats page.
Jira issue: CRDB-21374
The text was updated successfully, but these errors were encountered: