Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

insights: add statement contention events to ui #91187

Closed
j82w opened this issue Nov 3, 2022 · 0 comments · Fixed by #91668
Closed

insights: add statement contention events to ui #91187

j82w opened this issue Nov 3, 2022 · 0 comments · Fixed by #91668
Assignees
@j82w
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@j82w
Copy link
Contributor

j82w commented Nov 3, 2022 •
edited by cockroach-jira-scripts
Loading

This issue added contention events to the insights table. These new events need to be added to the insights statement details page.

Jira issue: CRDB-21141
@j82w j82w added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-observability labels Nov 3, 2022
@j82w j82w self-assigned this Nov 3, 2022
@j82w j82w mentioned this issue Nov 10, 2022
Merged
craig bot pushed a commit that referenced this issue Nov 15, 2022
@stevendanna
Merge #91668 #91942
db73c5e 
91668: ui: add contention info to insight statement details r=j82w a=j82w

This changes the crdb_internal.cluster_execution_insights to store 
the names of contention key instead of
the ids. This avoids complex join logic so the
ui can display a eas format.

This does not currently contain the blocking
transaction fingerprint or the blocking statement
information. The blocking fingerprint will be added in issue #91665 

closes: #91187

https://www.loom.com/share/03e08c5a473844b3a637b9eb618b7866

Release note (ui change): Add the contention
time, schema, database, table, and index info
to insights statement details page.

91942: sql: use empty roachpb.TenantID for error return r=michae2 a=stevendanna

MakeTenantID(0) panics. In other error cases in the code base, we return an empty struct.

Epic: None

Release note: None

Co-authored-by: j82w <[email protected]>
Co-authored-by: Steven Danna <[email protected]>
@craig craig bot closed this as completed in 2051d23 Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j82w j82w

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: add contention info to insight statement details
1 participant
@j82w