scbuild: audit builder for low-hanging fruit #96496
Labels
A-schema-changes
C-cleanup
Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
While hacking on DROP TYPE CASCADE today I noticed there are quite a few instances in the builder where we throw NotImplemented errors in cases where we used to not be able to do a schema change because it would rely on functionality which wasn't there yet, but that functionality has since been added. I noticed this in particular in DROP COLUMN where we give up if the column is referenced in a constraint, but support for dropping constraint was added a few days ago.
Another aspect is unsupported syntax. I noticed that ADD UNIQUE was unsupported, but it would be trivial to add support for it.
It's hard to do these kinds of things when adding new functionality but it'd be good to go over this no later than the very beginning of stability period.
Jira issue: CRDB-24154
The text was updated successfully, but these errors were encountered: