Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scbuild: audit builder for low-hanging fruit #96496

Closed
postamar opened this issue Feb 3, 2023 · 2 comments
Closed

scbuild: audit builder for low-hanging fruit #96496

postamar opened this issue Feb 3, 2023 · 2 comments
Assignees
Labels
A-schema-changes C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@postamar
Copy link
Contributor

postamar commented Feb 3, 2023

While hacking on DROP TYPE CASCADE today I noticed there are quite a few instances in the builder where we throw NotImplemented errors in cases where we used to not be able to do a schema change because it would rely on functionality which wasn't there yet, but that functionality has since been added. I noticed this in particular in DROP COLUMN where we give up if the column is referenced in a constraint, but support for dropping constraint was added a few days ago.

Another aspect is unsupported syntax. I noticed that ADD UNIQUE was unsupported, but it would be trivial to add support for it.

It's hard to do these kinds of things when adding new functionality but it'd be good to go over this no later than the very beginning of stability period.

Jira issue: CRDB-24154

@postamar postamar added the C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. label Feb 3, 2023
@blathers-crl blathers-crl bot added the T-sql-schema-deprecated Use T-sql-foundations instead label Feb 3, 2023
@postamar postamar changed the title schemachanger: audit builder for low-hanging fruit scbuild: audit builder for low-hanging fruit Feb 3, 2023
@ajwerner
Copy link
Contributor

ajwerner commented Feb 7, 2023

@Xiang-Gu I see you did some of this. Can you wrap up your assessment by filing issues, linking them here and closing this?

@Xiang-Gu
Copy link
Contributor

Xiang-Gu commented Feb 7, 2023

I quickly comb over the builder and filed the following individual things we should be able to do without much hassle:
#96731
#96727
#96728
#96729
#96730

I'm closing this in favor of the above individual issues.

@Xiang-Gu Xiang-Gu closed this as completed Feb 7, 2023
@exalate-issue-sync exalate-issue-sync bot reopened this May 10, 2023
@exalate-issue-sync exalate-issue-sync bot added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 10, 2023
@rafiss rafiss closed this as completed May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-schema-changes C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Development

No branches or pull requests

4 participants