Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schemachanger: Support ADD PRIMARY KEY NOT VALID #96729

Closed
Xiang-Gu opened this issue Feb 7, 2023 · 0 comments · Fixed by #97746
Closed

schemachanger: Support ADD PRIMARY KEY NOT VALID #96729

Xiang-Gu opened this issue Feb 7, 2023 · 0 comments · Fixed by #97746
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@Xiang-Gu
Copy link
Contributor

Xiang-Gu commented Feb 7, 2023 •
edited by cockroach-jira-scripts
Loading

The legacy schema changer implemented ADD PRIMARY KEY NOT VALID in the exactly same way as
ADD PRIMARY KEY. The declarative schema changer should also follow the same behavior but maybe
send a notice to the user.

Jira issue: CRDB-24901
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql,schemachanger: ADD PRIMARY KEY NOT VALID returns an error Xiang-Gu/cockroach
1 participant
@Xiang-Gu