Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schemachanger: Drop columns that are used in constraints #96727

Closed
Xiang-Gu opened this issue Feb 7, 2023 · 2 comments · Fixed by #97579
Closed

schemachanger: Drop columns that are used in constraints #96727

Xiang-Gu opened this issue Feb 7, 2023 · 2 comments · Fixed by #97579
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@Xiang-Gu
Copy link
Contributor

Xiang-Gu commented Feb 7, 2023

The new schema changer falls back when dropping a column that is used in a constraint. Now that adding/dropping
constraints are supported. We should be able to fix this.
@Xiang-Gu Xiang-Gu added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Feb 7, 2023
@blathers-crl blathers-crl bot added the T-sql-schema-deprecated Use T-sql-foundations instead label Feb 7, 2023
@Xiang-Gu Xiang-Gu mentioned this issue Feb 7, 2023
Closed
@ajwerner
Copy link
Contributor

@Xiang-Gu to split into two sub-issues.

@Xiang-Gu Xiang-Gu mentioned this issue Feb 23, 2023
Merged
@Xiang-Gu
Copy link
Contributor Author

There is one closely related issue: drop UWIs with dependent, inbound FKs. The PR above will solve both issues.

@craig craig bot closed this as completed in 7a3778b Feb 27, 2023
@healthy-pod healthy-pod added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

schemachanger: Support dropping column with referenced constraints Xiang-Gu/cockroach
3 participants
@ajwerner @healthy-pod @Xiang-Gu