Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schemachanger: Support DROP INDEX with dependent FK constraint #96731

Closed
Xiang-Gu opened this issue Feb 7, 2023 · 0 comments · Fixed by #97065
Closed

schemachanger: Support DROP INDEX with dependent FK constraint #96731

Xiang-Gu opened this issue Feb 7, 2023 · 0 comments · Fixed by #97065
Assignees
@Xiang-Gu
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@Xiang-Gu
Copy link
Contributor

Xiang-Gu commented Feb 7, 2023 •
edited by cockroach-jira-scripts
Loading

If we were to drop a unique secondary index cascade and this unique index backed a FK constraint
in the referenced table, we should drop the index and the FK constraint. Presently, the declarative schema
changer just fallback. Now that we have supported dropping FK constraint, we should be able to support
this in the declarative schema changer.

Jira issue: CRDB-24297
@Xiang-Gu Xiang-Gu added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Feb 7, 2023
@blathers-crl blathers-crl bot added the T-sql-schema-deprecated Use T-sql-foundations instead label Feb 7, 2023
This was referenced Feb 7, 2023
Closed
Merged
@craig craig bot closed this as completed in b3231c0 Feb 22, 2023
@exalate-issue-sync exalate-issue-sync bot added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xiang-Gu Xiang-Gu

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

schemachanger: Support dropping index cascade with dependent inbound FK Xiang-Gu/cockroach
1 participant
@Xiang-Gu