logictest: add tenant capability directives #96189
Assignees
Labels
A-multitenancy
Related to multi-tenancy
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Comments
ecwall
added
C-enhancement
This was referenced Jan 30, 2023
craig bot
pushed a commit
that referenced
this issue
Feb 1, 2023
96114: logictest: parameterize cluster setting directives r=arulajmani a=ecwall Informs #96189 Cluster setting directives are currently hard coded which requires boiler plate each time a new one is added. example: ``` tenant-cluster-setting-override-opt: allow-zone-configs-for-secondary-tenants ``` This patch makes the cluster setting directives parameterized with the cluster setting name and value to avoid this. example: ``` tenant-cluster-setting-override-opt: sql.zone_configs.allow_for_secondary_tenant.enabled=true ``` Logic tests for tenant capabilities should have a directive to set capabilities similar to cluster settings. This will be done in a separate PR, but the goal is to be able to set them like this: ``` tenant-capability-override-opt: can_admin_split=true ``` Release note: None Co-authored-by: Evan Wall <[email protected]>
craig bot
pushed a commit
that referenced
this issue
Feb 2, 2023
95544: Update sarama and goavro dependencies r=shermanCRL a=shermanCRL Just a deps update, not driven by a particular issue, but to not be a year behind in the next release. Brings along updates to x/net, x/sync, xdg-go/scram and other indirect dependencies. Addresses #81907 Release note: Avro decimal encoding is now higher precision, which we believe to be an improvement/bug fix. Jira: none Epic: none 95622: backupccl,storage: add logs around manifest handling and ExportRequest pagination r=stevendanna a=adityamaru backupccl: add logging to backup manifest handling Release note: None storage: log the ExportRequest pagination reason Release note: None Epic: None 95805: streamingest,jobspb,sql: adding a `replication pending cutover` state r=lidorcarmel a=lidorcarmel Before this pr the state of the tenant was calculated by looking at several proto fields in the job info. This pr adds a new field in the replication job with the state of the replication tenant. Also, this pr adds a `replication pending cutover` state for a tenant that has a cutover time in the future. Epic: [CRDB-18752](https://cockroachlabs.atlassian.net/browse/CRDB-18752) Release note: None 96010: codeowners: tenant streaming team → disaster recovery r=shermanCRL a=shermanCRL Cleanup of old CODEOWNERS todo, C2C failures were not notifying the right team. Jira: none Epic: none 96191: logictest: parameterize capability directives r=knz a=ecwall Fixes #96189 Add tenant capability directives that work similarly to tenant cluster setting directives. These capabilities are set after the test server starts and apply to all test configs, but only affect secondary tenants. Release note: None 96338: rpc/auth: simplify the control flow further r=stevendanna a=knz Steven made a good point that we can split the big authenticate function into two smaller functions. Release note: None Epic: CRDB-14537 Co-authored-by: Steven Danna <[email protected]> 96340: changefeedccl: Bump default per changefeed limit r=miretskiy a=miretskiy Inrease default changefeed limit to 512MiB. The limit was previously reduced from 1GiB due to the concerns of changefeed impact on foreground latency. That impact in turn was due how changefeed allocated and management memory. The issue leading to the reduction in this setting default have been addressed (via improvememnts in memory management, leading to the changefeed impact reduction on the Go runtime, as well as addition of CPU pacing). The 128MiB default limit is too low for file based sinks. By default, those sinks buffer 16MB of data, and often times this is combined with compression. If the data is highly compressible (5-10x, which is not uncommon), changefeds wind up using the entirety of memory budget, before reaching their target file size, resulting in small files being produced. This PR splits a difference between original, 1GiB setting, and the new 128MiB setting by increasing default setting to 1/2GiB. Epic: None Release note (enterprise change): Bump up default `changefeed.memory.per_changefeed_limit` setting to 1/2GiB. This should result in changefeeds being able to produce larger files. 96366: release: skip nil GitHub events r=celiala a=rail Previously, we referenced `*event.Event`, but in some cases the event objects are `nil`. This PR skips the nil GitHub event objects. Epic: none Release note: None Co-authored-by: Matt Sherman <[email protected]> Co-authored-by: adityamaru <[email protected]> Co-authored-by: Lidor Carmel <[email protected]> Co-authored-by: Evan Wall <[email protected]> Co-authored-by: Raphael 'kena' Poss <[email protected]> Co-authored-by: Yevgeniy Miretskiy <[email protected]> Co-authored-by: Rail Aliiev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Logic tests for tenant capabilities should have a directive
to set capabilities similar to cluster settings.
Cluster setting directives are currently hard coded which requires
boiler plate each time a new one is added.
Make the cluster setting directives parameterized to avoid this.
Jira issue: CRDB-23993
Epic CRDB-19504
The text was updated successfully, but these errors were encountered: