Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bulk, cdc: update SDKs for v23.1 #81907

Closed
1 of 9 tasks
shermanCRL opened this issue May 26, 2022 · 3 comments
Closed
1 of 9 tasks

bulk, cdc: update SDKs for v23.1 #81907

shermanCRL opened this issue May 26, 2022 · 3 comments
Labels
A-cdc Change Data Capture A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-cdc

Comments

@shermanCRL
Copy link
Contributor

shermanCRL commented May 26, 2022

Let’s upgrade our dependencies for the following, for the 22.2 cycle:

Here’s the current go.mod.

Let’s be methodical, within reasonable time limits:

  • Pick a version that has baked for a while, not necessarily the latest. Look for a high patch number.
  • Read the commit history between old and new version
    • Optionally, read the diff, though this may be too big
  • One commit for each, so we can bisect/revert

Have a look at how we did this in the previous cycle.

Why do this?

I (@shermanCRL) feel that we should eagerly stay up to date, on the assumption (bet) that there are bug fixes in later versions. There may also be functionality or performance enhancements.

Keep in mind our six-month release cycle, and our customers’ pace of upgrade: these dependencies running in production will almost certainly be six months or a year old. Let’s not let it become 18 months or two years. We’d hate to hear about a bug that was fixed in the dependency a while ago, but we didn’t pick it up.

Jira issue: CRDB-16127

Epic CRDB-25043

@shermanCRL shermanCRL added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-disaster-recovery labels May 26, 2022
@blathers-crl
Copy link

blathers-crl bot commented May 26, 2022

cc @cockroachdb/bulk-io

@shermanCRL shermanCRL added A-cdc Change Data Capture and removed A-disaster-recovery labels May 26, 2022
@blathers-crl blathers-crl bot added the T-cdc label May 26, 2022
@blathers-crl
Copy link

blathers-crl bot commented May 26, 2022

cc @cockroachdb/cdc

@livlobo
Copy link
Contributor

livlobo commented Jun 7, 2022

@rhu713 - tag link to issue in 22.1

@shermanCRL shermanCRL changed the title bulk, cdc: update SDKs for v22.2 bulk, cdc: update SDKs for v23.1 Jan 19, 2023
craig bot pushed a commit that referenced this issue Feb 2, 2023
95544: Update sarama and goavro dependencies r=shermanCRL a=shermanCRL

Just a deps update, not driven by a particular issue, but to not be a year behind in the next release.

Brings along updates to x/net, x/sync, xdg-go/scram and other indirect dependencies.

Addresses #81907

Release note: Avro decimal encoding is now higher precision, which we believe to be an improvement/bug fix.

Jira: none
Epic: none

95622: backupccl,storage: add logs around manifest handling and ExportRequest pagination r=stevendanna a=adityamaru

backupccl: add logging to backup manifest handling

Release note: None

storage: log the ExportRequest pagination reason

Release note: None

Epic: None

95805: streamingest,jobspb,sql: adding a `replication pending cutover` state r=lidorcarmel a=lidorcarmel

Before this pr the state of the tenant was calculated by looking at
several proto fields in the job info. This pr adds a new field in the
replication job with the state of the replication tenant.

Also, this pr adds a `replication pending cutover` state for a tenant
that has a cutover time in the future.

Epic: [CRDB-18752](https://cockroachlabs.atlassian.net/browse/CRDB-18752)

Release note: None

96010: codeowners: tenant streaming team → disaster recovery r=shermanCRL a=shermanCRL

Cleanup of old CODEOWNERS todo, C2C failures were not notifying the right team. 

Jira: none
Epic: none

96191: logictest: parameterize capability directives r=knz a=ecwall

Fixes #96189

Add tenant capability directives that work similarly to
tenant cluster setting directives.

These capabilities are set after the test server starts and apply to
all test configs, but only affect secondary tenants.

Release note: None

96338: rpc/auth: simplify the control flow further r=stevendanna a=knz

Steven made a good point that we can split the big authenticate function into two smaller functions.

Release note: None
Epic: CRDB-14537

Co-authored-by: Steven Danna <[email protected]>

96340: changefeedccl: Bump default per changefeed limit r=miretskiy a=miretskiy

Inrease default changefeed limit to 512MiB.
The limit was previously reduced from 1GiB due to the concerns of changefeed impact on foreground latency. That impact in turn was due how changefeed allocated and management memory.  The issue leading to the reduction in this setting default have been addressed (via
improvememnts in memory management, leading to the changefeed impact reduction on the Go runtime, as well as addition of CPU pacing).

The 128MiB default limit is too low for file based sinks. By default, those sinks buffer 16MB of data, and often times this is combined with compression.  If the data is highly compressible (5-10x, which is not uncommon), changefeds wind up using the entirety of memory budget, before reaching their target file size, resulting in small files being produced.

This PR splits a difference between original, 1GiB setting, and the new 128MiB setting by increasing default setting to 1/2GiB.

Epic: None

Release note (enterprise change): Bump up default
`changefeed.memory.per_changefeed_limit` setting to 1/2GiB. This should result in changefeeds being able to produce larger files.

96366: release: skip nil GitHub events r=celiala a=rail

Previously, we referenced `*event.Event`, but in some cases the event objects are `nil`.

This PR skips the nil GitHub event objects.

Epic: none
Release note: None

Co-authored-by: Matt Sherman <[email protected]>
Co-authored-by: adityamaru <[email protected]>
Co-authored-by: Lidor Carmel <[email protected]>
Co-authored-by: Evan Wall <[email protected]>
Co-authored-by: Raphael 'kena' Poss <[email protected]>
Co-authored-by: Yevgeniy Miretskiy <[email protected]>
Co-authored-by: Rail Aliiev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cdc Change Data Capture A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-cdc
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants