changefeedccl: Bump default per changefeed limit #96340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inrease default changefeed limit to 512MiB. The limit was previously reduced from 1GiB due to the concerns of changefeed impact on foreground latency. That impact in turn was due how changefeed allocated and management memory. The issue leading to the reduction in this setting default have been addressed (via improvememnts in memory management, leading to the changefeed impact reduction on the Go runtime, as well as addition of CPU pacing). The 128MiB default limit is too low for file based sinks. By default, those sinks buffer 16MB of data, and often times this is combined with compression. If the data is highly compressible (5-10x, which is not uncommon), changefeds wind up using the entirety of memory budget, before reaching their target file size, resulting in small files being produced. This PR splits a difference between original, 1GiB setting, and the new 128MiB setting by increasing default setting to 1/2GiB. Epic: None Release note (enterprise change): Bump up default `changefeed.memory.per_changefeed_limit` setting to 1/2GiB. This should result in changefeeds being able to produce larger files.
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
shermanCRL
approved these changes
Feb 1, 2023
|
bors r+ |
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inrease default changefeed limit to 512MiB.
The limit was previously reduced from 1GiB due to the concerns of changefeed impact on foreground latency. That impact in turn was due how changefeed allocated and management memory. The issue leading to the reduction in this setting default have been addressed (via
improvememnts in memory management, leading to the changefeed impact reduction on the Go runtime, as well as addition of CPU pacing).
The 128MiB default limit is too low for file based sinks. By default, those sinks buffer 16MB of data, and often times this is combined with compression. If the data is highly compressible (5-10x, which is not uncommon), changefeds wind up using the entirety of memory budget, before reaching their target file size, resulting in small files being produced.
This PR splits a difference between original, 1GiB setting, and the new 128MiB setting by increasing default setting to 1/2GiB.
Epic: None
Release note (enterprise change): Bump up default
changefeed.memory.per_changefeed_limitsetting to 1/2GiB. This should result in changefeeds being able to produce larger files.