sql: Internal Error when using invalid range condition

[SteveLeungYL]

Describe the problem

The latest version of the CockroachDB (b861696) shows Internal Error when executing the following query:

 SELECT NULL FROM ROWS FROM (SUM(*)) AS OF SYSTEM TIME ('' BETWEEN '' AND '');

To Reproduce

Here is the detail steps to reproduce the bug.

1. In operating system Ubuntu 20.04, download the CockroachDB source code from the github source.
2. Use the latest version of the CockroachDB code (tested version: b861696)
3. Directly make install in the root repository folder.
4. Run ./cockroach demo, and then paste the PoC query to the cockroach cli environment.
5. Observe the Internal Error and log the stack information.

Expected behavior

The SELECT statement's result should be a semantic error.

Additional data / screenshots

Here is the outputted stack trace:

[email protected]:26257/movr> SELECT NULL FROM ROWS FROM (SUM(*)) AS OF SYSTEM TIME ('' BETWEEN '' AND '');
ERROR: internal error: unhandled type *tree.RangeCond
SQLSTATE: XX000
DETAIL: stack trace:
github.com/cockroachdb/cockroach/pkg/sql/sem/eval/expr.go:611: EvalRangeCond()
github.com/cockroachdb/cockroach/pkg/sql/sem/tree/eval_expr_generated.go:341: Eval()
github.com/cockroachdb/cockroach/pkg/sql/sem/eval/expr.go:26: Expr()
github.com/cockroachdb/cockroach/pkg/sql/sem/asof/as_of.go:196: Eval()
github.com/cockroachdb/cockroach/pkg/sql/exec_util.go:1898: EvalAsOfTimestamp()
github.com/cockroachdb/cockroach/pkg/sql/exec_util.go:1952: isAsOf()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:806: handleAOST()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:658: execStmtInOpenState()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:130: func1()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:2527: execWithProfiling()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:129: execStmt()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1959: func1()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1964: execCmd()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1882: run()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:836: ServeConn()
github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:731: func1()
runtime/asm_arm64.s:1165: goexit()

HINT: You have encountered an unexpected error.

Environment:

• CockroachDB version: v23.1.0-alpha
• Server OS: Ubuntu 20.04 LTS
• Client app: CockroachDB demo command. (./cockroach demo)
• Detailed CockroachDB version output:

cockroach version details:
Build Tag:        v23.1.0-alpha.1-1132-gb861696207
Build Time:       2023/01/20 18:12:24
Distribution:     CCL
Platform:         linux arm64 (aarch64-linux-gnu)
Go Version:       go1.19
C Compiler:       gcc 9.4.0
Build Commit ID:  b861696207d6640f187add625ac6e4bb7b9575d4
Build Type:       development

Additional context

The bug can be reproduced by CockroachDB release version: CockroachDB v23.1 Testing Releases , v22.2.2 and v22.1. We haven't tested versions before v22.1.

Jira issue: CRDB-23610

[blathers-crl]

Hello, I am Blathers. I am here to help you get the issue triaged.

Hoot - a bug! Though bugs are the bane of my existence, rest assured the wretched thing will get the best of care here.

I was unable to automatically find someone to ping.

If we have not gotten back to your issue within a few business days, you can try the following:

• Join our community slack channel and ask on #cockroachdb.
• Try find someone from here if you know they worked closely on the area and CC them.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}