workflow: Cluster UI autopublishing configuration fixes #96121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Using action `actions/setup-node@v3` we need to provide specific configuration for the internally generated `.npmrc`. This commit sets `registry-url` and `always-auth` to be explicit and changes the environment variable `NPM_TOKEN` to `NODE_AUTH_TOKEN` since this is what the action uses internally to set the auth token. I'm also switching back to using `npm` to publish as the setup-node action uses Yarn2 internally which can not read npm configuration and must have its own `.yarnrc.yml` generated. A couple more improvements were made (since I was here), - Add explicit output when a package should be published - Check for the existence of a git tag before creating one (to prevent duplicates) - Adds `--ignore-scripts` option to publish command to prevent duplicate builds. Epic: none Release note: None
nathanstilwell
force-pushed
the
nathanstilwell/cluster-ui-autopub-test-next
branch
from
cc9413d to
63aedbf
Compare
maryliag
approved these changes
Jan 27, 2023
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @sjbarag)
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using action
actions/setup-node@v3we need to provide specific configuration for the internally generated.npmrc. This commit setsregistry-urlandalways-authto be explicit and changes the environment variableNPM_TOKENtoNODE_AUTH_TOKENsince this is what the action uses internally to set the auth token. I'm also switching back to usingnpmto publish as the setup-node action uses Yarn2 internally which can not read npm configuration and must have its own.yarnrc.ymlgenerated.A couple more improvements were made (since I was here),
--ignore-scriptsoption to publish command to prevent duplicate builds.Test publish - Publish Cluster UI Pre-release #73 (published 23.1.0-publishtest.0 and created tag)
Epic: none
Release note: None