Merge #96105 #96113 #96121

96105: sql: add logic test for function dropped by DROP OWNED BY r=chengxiong-ruan a=chengxiong-ruan

With DROP FUNCTION supported in declarative schema changer, DROP OWNED BY can now drop functions.

Epic: None

Release note: None

96113: asof: fix internal error on AOST expression requiring normalization r=ajwerner a=msirek

Fixes #95604

This adds missing normalization of AS OF SYSTEM TIME expressions. Without normalization, some expressions such as range conditions may result in an internal error.

Release note (bug fix): This patch fixes internal errors which may occur on some AS OF SYSTEM TIME expressions.

96121: workflow: Cluster UI autopublishing configuration fixes r=nathanstilwell a=nathanstilwell

Using action `actions/setup-node@v3` we need to provide specific configuration for the internally generated `.npmrc`. This commit sets `registry-url` and `always-auth` to be explicit and changes the environment variable `NPM_TOKEN` to `NODE_AUTH_TOKEN` since this is what the action uses internally to set the auth token. I'm also switching back to using `npm` to publish as the setup-node action uses Yarn2 internally which can not read npm configuration and must have its own `.yarnrc.yml` generated.

A couple more improvements were made (since I was here),
- Add explicit output when a package should be published
- Check for the existence of a git tag before creating one (to prevent duplicates)
- Adds `--ignore-scripts` option to publish command to prevent duplicate builds.

Test publish - [Publish Cluster UI Pre-release #73](https://github.com/cockroachdb/cockroach/actions/runs/4027917363) (published [23.1.0-publishtest.0](https://www.npmjs.com/package/`@cockroachlabs/cluster-ui/v/23.1.0-publishtest.0)` and created [tag](https://github.com/cockroachdb/cockroach/releases/tag/%40cockroachlabs%2Fcluster-ui%4023.1.0-publishtest.0)) 

Epic: none

Release note: None

Co-authored-by: Chengxiong Ruan <[email protected]>
Co-authored-by: Mark Sirek <[email protected]>
Co-authored-by: Nathan Stilwell <[email protected]>

.github/workflows/cluster-ui-release-next.yml

@@ -1,5 +1,6 @@
 name: Publish Cluster UI Pre-release
 on:
+  workflow_dispatch:
   push:
     branches:
       - master
@@ -31,10 +32,12 @@ jobs:
       uses: actions/setup-node@v3
       with:
         node-version: 16
+        registry-url: 'https://registry.npmjs.org'
+        always-auth: true
         cache: 'yarn'
         cache-dependency-path: pkg/ui/workspaces/cluster-ui/yarn.lock
       env:
-        NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
+        NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
 
     - name: Check if version is published
       id: version-check
@@ -49,6 +52,8 @@ jobs:
           echo "to npm. Publishing step should be skipped. 🛑"
         else
           echo "published=no" >> $GITHUB_OUTPUT
+          echo
+          echo "✅ Cluster UI package version $PACKAGE_VERSION should be published. ✅"
         fi
 
     - name: Build Cluster UI
@@ -62,10 +67,12 @@ jobs:
     - name: Create version tag and push
       if: steps.version-check.outputs.published == 'no'
       run: |
-        TAGNAME="@cockroachlabs/cluster-ui@$(cat ./package.json | jq -r '.version')"
-        git tag $TAGNAME
-        git push origin $TAGNAME
+        TAGNAME="@cockroachlabs/cluster-ui@$(jq -r '.version' ./package.json)"
+        if ! [ $(git tag -l "$TAGNAME") ]; then
+          git tag $TAGNAME
+          git push origin $TAGNAME
+        fi
 
     - name: Publish prerelease version
       if: steps.version-check.outputs.published == 'no'
-      run: yarn publish --access public --tag next
+      run: npm publish --access public --tag next --ignore-scripts

.github/workflows/cluster-ui-release.yml

@@ -1,5 +1,6 @@
 name: Publish Cluster UI Release
 on:
+  workflow_dispatch:
   push:
     branches:
       - 'release-*'
@@ -31,10 +32,12 @@ jobs:
       uses: actions/setup-node@v3
       with:
         node-version: 16
+        registry-url: 'https://registry.npmjs.org'
+        always-auth: true
         cache: 'yarn'
         cache-dependency-path: pkg/ui/workspaces/cluster-ui/yarn.lock
       env:
-        NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
+        NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
 
     - name: Check if version is published
       id: version-check
@@ -49,6 +52,8 @@ jobs:
           echo "to npm. Publishing step should be skipped. 🛑"
         else
           echo "published=no" >> $GITHUB_OUTPUT
+          echo
+          echo "✅ Cluster UI package version $PACKAGE_VERSION should be published. ✅"
         fi
 
     - name: Get Branch name
@@ -67,10 +72,12 @@ jobs:
     - name: Create version tag and push
       if: steps.version-check.outputs.published == 'no'
       run: |
-        TAGNAME="@cockroachlabs/cluster-ui@$(cat ./package.json | jq -r '.version')"
-        git tag $TAGNAME
-        git push origin $TAGNAME
+        TAGNAME="@cockroachlabs/cluster-ui@$(jq -r '.version' ./package.json)"
+        if ! [ $(git tag -l "$TAGNAME") ]; then
+          git tag $TAGNAME
+          git push origin $TAGNAME
+        fi
 
     - name: Publish patch version
       if: steps.version-check.outputs.published == 'no'
-      run: yarn publish --access public --tag ${{ steps.branch-name.outputs.branch }}
+      run: npm publish --access public --tag ${{ steps.branch-name.outputs.branch }} --ignore-scripts

pkg/sql/logictest/testdata/logic_test/as_of

@@ -142,3 +142,8 @@ SET TRANSACTION AS OF system time '-1s'
 
 statement ok
 ROLLBACK
+
+# Verify that an expression that requires normalization does not result in an
+# internal error.
+statement error pq: AS OF SYSTEM TIME: expected timestamp, decimal, or interval, got bool
+SELECT * FROM t AS OF SYSTEM TIME ('' BETWEEN '' AND '')

pkg/sql/logictest/testdata/logic_test/drop_owned_by

@@ -633,3 +633,20 @@ GRANT SYSTEM MODIFYCLUSTERSETTING TO testuser
 
 statement error pq: cannot perform drop owned by if role has synthetic privileges; testuser has entries in system.privileges
 DROP OWNED BY testuser
+
+subtest drop_function
+
+statement ok
+CREATE USER u_drop_udf;
+
+statement ok
+CREATE FUNCTION f_drop_udf() RETURNS INT LANGUAGE SQL AS $$ SELECT 1 $$;
+
+statement ok
+ALTER FUNCTION f_drop_udf OWNER TO u_drop_udf;
+
+statement ok
+DROP OWNED BY u_drop_udf;
+
+statement error pq: unknown function: f_drop_udf\(\): function undefined
+SHOW CREATE FUNCTION f_drop_udf;

pkg/sql/sem/asof/BUILD.bazel

@@ -10,6 +10,7 @@ go_library(
         "//pkg/sql/pgwire/pgcode",
         "//pkg/sql/pgwire/pgerror",
         "//pkg/sql/sem/eval",
+        "//pkg/sql/sem/normalize",
         "//pkg/sql/sem/tree",
         "//pkg/sql/types",
         "//pkg/util/duration",

pkg/sql/sem/asof/as_of.go

@@ -20,6 +20,7 @@ import (
 	"github.com/cockroachdb/cockroach/pkg/sql/pgwire/pgcode"
 	"github.com/cockroachdb/cockroach/pkg/sql/pgwire/pgerror"
 	"github.com/cockroachdb/cockroach/pkg/sql/sem/eval"
+	"github.com/cockroachdb/cockroach/pkg/sql/sem/normalize"
 	"github.com/cockroachdb/cockroach/pkg/sql/sem/tree"
 	"github.com/cockroachdb/cockroach/pkg/sql/types"
 	"github.com/cockroachdb/cockroach/pkg/util/duration"
@@ -192,7 +193,10 @@ func Eval(
 			return eval.AsOfSystemTime{}, newInvalidExprError()
 		}
 	}
-
+	var err error
+	if te, err = normalize.Expr(ctx, evalCtx, te); err != nil {
+		return eval.AsOfSystemTime{}, err
+	}
 	d, err := eval.Expr(ctx, evalCtx, te)
 	if err != nil {
 		return eval.AsOfSystemTime{}, err