sql: panic when interacting with BIT array

[SteveLeungYL]

Describe the problem

The latest version of the CockroachDB (9735954) shows Internal Error when executing the following query:

CREATE TABLE v0 (c1 BIT PRIMARY KEY ); -- PRIMARY KEY is required to trigger the bug
SELECT * FROM [SHOW RANGE FROM TABLE v0 FOR ROW ( b'\x68')];

To Reproduce

Here is the detail steps to reproduce the bug.

1. In operating system Ubuntu 20.04, download the CockroachDB source code from the github source.
2. Use the latest version of the CockroachDB code (tested version: 9735954)
3. Directly make install in the root repository folder.
4. Run ./cockroach demo, and then paste the PoC query to the cockroach cli environment.
5. Observe the Internal Error and log the stack information.

Expected behavior
The select statement should be executed correctly and outputs empty result.

Additional data / screenshots

Here is the outputted stack trace:

[email protected]:26257/movr> CREATE TABLE v0 (c1 BIT PRIMARY KEY ); -- PRIMARY KEY is required to trigger the bug
CREATE TABLE

Time: 3ms total (execution 3ms / network 0ms)

[email protected]:26257/movr> SELECT * FROM [SHOW RANGE FROM TABLE v0 FOR ROW ( b'\x68')];
ERROR: internal error: runtime error: invalid memory address or nil pointer dereference
SQLSTATE: XX000
DETAIL: stack trace:
github.com/cockroachdb/cockroach/pkg/util/errorutil/catch.go:29: ShouldCatch()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/builder.go:193: func1()
runtime/panic.go:884: gopanic()
runtime/panic.go:260: panicmem()
runtime/signal_unix.go:835: sigpanic()
github.com/cockroachdb/cockroach/pkg/sql/sem/tree/parse_string.go:129: FormatBitArrayToType()
github.com/cockroachdb/cockroach/pkg/sql/sem/eval/cast.go:153: performCastWithoutPrecisionTruncation()
github.com/cockroachdb/cockroach/pkg/sql/sem/eval/cast.go:67: PerformCast()
github.com/cockroachdb/cockroach/pkg/sql/sem/builtins/builtins.go:5087: 1()
github.com/cockroachdb/cockroach/pkg/sql/evalcatalog/encode_table_index_key.go:114: EncodeTableIndexKey()
github.com/cockroachdb/cockroach/pkg/sql/sem/builtins/builtins.go:5082: func239()
github.com/cockroachdb/cockroach/pkg/sql/sem/eval/expr.go:479: EvalFuncExpr()
github.com/cockroachdb/cockroach/pkg/sql/sem/tree/eval_expr_generated.go:276: Eval()
github.com/cockroachdb/cockroach/pkg/sql/sem/eval/expr.go:26: Expr()
github.com/cockroachdb/cockroach/pkg/sql/opt/norm/fold_constants_funcs.go:687: FoldFunction()
github.com/cockroachdb/cockroach/pkg/sql/opt/norm/factory.og.go:20127: ConstructFunction()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/scalar.go:569: buildFunction()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/scalar.go:333: buildScalar()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/scalar.go:321: buildScalar()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/scalar.go:126: buildScalar()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/util.go:463: resolveAndBuildScalar()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/select.go:1165: buildWhere()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/select.go:1047: buildSelectClause()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/select.go:992: buildSelectStmtWithoutParens()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/select.go:961: func1()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/with.go:117: processWiths()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/select.go:960: buildSelect()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/builder.go:307: buildStmt()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/builder.go:405: buildStmt()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/select.go:172: buildDataSource()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/select.go:67: buildDataSource()
github.com/cockroachdb/cockroach/pkg/sql/opt/optbuilder/select.go:1219: buildFromTablesRightDeep()

HINT: You have encountered an unexpected error.

Environment:

• CockroachDB version: v23.1.0-alpha
• Server OS: Ubuntu 20.04 LTS
• Client app: CockroachDB demo command. (./cockroach demo)
• Detailed CockroachDB version output:

cockroach version details:
Build Tag:        v23.1.0-alpha.1-1099-g97359549f1
Build Time:       2023/01/19 20:06:56
Distribution:     CCL
Platform:         linux arm64 (aarch64-linux-gnu)
Go Version:       go1.19
C Compiler:       gcc 9.4.0
Build Commit ID:  97359549f19a64113965331164e7aff005a766be
Build Type:       development

Additional context

The Internal Error can be reproduced by CockroachDB v23.1 Testing Releases , v22.2.2 and v22.1. We haven't tested earlier versions.

Jira issue: CRDB-23581

[blathers-crl]

Hello, I am Blathers. I am here to help you get the issue triaged.

Hoot - a bug! Though bugs are the bane of my existence, rest assured the wretched thing will get the best of care here.

I was unable to automatically find someone to ping.

If we have not gotten back to your issue within a few business days, you can try the following:

• Join our community slack channel and ask on #cockroachdb.
• Try find someone from here if you know they worked closely on the area and CC them.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}